From owner-svn-ports-all@freebsd.org Fri Mar 25 17:52:37 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72F1FADD37D; Fri, 25 Mar 2016 17:52:37 +0000 (UTC) (envelope-from kubito@gmail.com) Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1C0AB19EC; Fri, 25 Mar 2016 17:52:37 +0000 (UTC) (envelope-from kubito@gmail.com) Received: by mail-wm0-x229.google.com with SMTP id p65so32716637wmp.1; Fri, 25 Mar 2016 10:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dpjAfrZVmE9WQuNvRF6xf0/RS7nlL8IuefAZ+WZcKH8=; b=XAt1dRaGohUJn9aeDcFPjxW7rKCUpgFmmGFLyFn3i7mmQzvy4aQklQPCAGFnTluG2Q J3rO2MBzGGE+DJYkFsaLmLNuF8n643jUwpaMs0mbDjhBelOGZXTbn0puXZavGk7UKXf/ aFXSs5L9b1ohjniTQdpx20CvQ9pOMkxdBh2//McD7p6AuA9/TsBTxrQV5mV/KY4CFv4S D8eg99W/YkYcYeUF45Ilx/Quhr01ndbwENT94SvgpjCs0T10z8OUi3LmCdt4E0nC+jWv txyFiBUL/mgYyI1O/xsPKe578ZdXX6QQd1MIZa3xMcEMvpeWWE0Vr5O63iIaqHH7KMxn x6jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=dpjAfrZVmE9WQuNvRF6xf0/RS7nlL8IuefAZ+WZcKH8=; b=QROnM76eV2ik1Nuxk+BAg0AYBgl0WgroDK6/T0nfhynwKZPOziv1eyZiI599Q7dL25 KJJVenyYRQkGvj/zPEDjVUfW0ZtSNtFW0I2fdv/vqo3REuuf3GTZlody3c7oEJ/Hldnr CJPxQLk//l2DX3Wnw1xpQ9y7trfYmuQLREdTzABt9drg2E/N1JXtNY+4FPi8VRrtuEzr ko/Sm6nvf3w0YYT7k8zhqEghHBBsE8skY/uRmtZxrUJkvIWcy1BQoH09UkKbBKqk/fn5 4BdfXwgyCM6fxN7Hl2FrKReLOllOSBL3og05wGmtvicCP0NKuai7FXn4Qe9cWe8JCB86 RHmw== X-Gm-Message-State: AD7BkJLATLB/p0U6KCg34flgiI4ZTFdpqx52xfx9yC+Va2CSt3jeVEqNfktAX0FCUJvZTw== X-Received: by 10.28.148.8 with SMTP id w8mr39935683wmd.90.1458928355666; Fri, 25 Mar 2016 10:52:35 -0700 (PDT) Received: from orwell.gmail.com (dhcp-077-248-147-050.chello.nl. [77.248.147.50]) by smtp.gmail.com with ESMTPSA id lh1sm12814548wjb.20.2016.03.25.10.52.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Mar 2016 10:52:35 -0700 (PDT) Sender: Raphael Kubo da Costa From: Raphael Kubo da Costa To: John Marino Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, marino@freebsd.org Subject: Re: svn commit: r411863 - head/graphics/digikam-kde4 References: <201603251629.u2PGTHEF009723@repo.freebsd.org> <56F567E5.4090905@marino.st> <86egayla41.fsf@FreeBSD.org> Date: Fri, 25 Mar 2016 18:52:34 +0100 In-Reply-To: <86egayla41.fsf@FreeBSD.org> (Raphael Kubo da Costa's message of "Fri, 25 Mar 2016 18:51:10 +0100") Message-ID: <86a8lmla1p.fsf@FreeBSD.org> User-Agent: Gnus/5.130016 (Ma Gnus v0.16) Emacs/24.5 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2016 17:52:37 -0000 Raphael Kubo da Costa writes: > John Marino writes: > >> On 3/25/2016 5:29 PM, Raphael Kubo da Costa wrote: >>> Author: rakuco >>> Date: Fri Mar 25 16:29:17 2016 >>> New Revision: 411863 >>> URL: https://svnweb.freebsd.org/changeset/ports/411863 >>> >>> Log: >>> Add USES=compiler:c++11-lang. >>> >>> This fixes digikam-kde4's build on 9.3 after the graphics/lensfun update in >>> r411373. >>> >>> lensfun.h includes C++ code (class and template declarations) inside an >>> extern "C" block that causes base GCC to fail: >> >> Not anymore. I patched it out yesterday (patch from upstream). Are you sure >> it wasn't building on 9.3 already after my change? > > I took the pkg-fallout emails at face value and only tested the port on > 9.3 after adding USES=compiler:c++11-lang, so it is possible that I can > revert this change indeed. > > However, the last commit to graphics/lensfun was r411373 from March > 18th. Should I be looking elsewhere for your commit? Duh, sorry for the brainfart. You actually patched digikam-kde4 itself in r411791, thanks for that. I'll double-check and revert this commit.