From owner-svn-ports-head@FreeBSD.ORG  Sun Dec 21 17:49:45 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A20CD9C;
 Sun, 21 Dec 2014 17:49:45 +0000 (UTC)
Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client CN "mouf.net", Issuer "mouf.net" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 64890208C;
 Sun, 21 Dec 2014 17:49:45 +0000 (UTC)
Received: from meatwad.mouf.net (cpe-107-015-170-205.nc.res.rr.com
 [107.15.170.205]) (authenticated bits=0)
 by mouf.net (8.14.5/8.14.5) with ESMTP id sBLHn0RS060625
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
 Sun, 21 Dec 2014 17:49:08 GMT (envelope-from swills@FreeBSD.org)
Message-ID: <549707F1.4070205@FreeBSD.org>
Date: Sun, 21 Dec 2014 17:48:33 +0000
From: Steve Wills <swills@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Adam Weinberger <adamw@adamw.org>
Subject: Re: svn commit: r375010 - head/Mk
References: <201412201559.sBKFxl9d088764@svn.freebsd.org>
 <46210F48-0FE2-4B61-AA64-17472B9EAEEB@adamw.org>
In-Reply-To: <46210F48-0FE2-4B61-AA64-17472B9EAEEB@adamw.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mouf.net [199.48.129.64]); Sun, 21 Dec 2014 17:49:12 +0000 (UTC)
X-Spam-Status: No, score=0.0 required=4.5 tests=none autolearn=unavailable
 autolearn_force=no version=3.4.0
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mouf.net
X-Virus-Scanned: clamav-milter 0.98.3 at mouf.net
X-Virus-Status: Clean
Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org,
 ports-committers@FreeBSD.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Dec 2014 17:49:45 -0000

On 12/21/14 15:15, Adam Weinberger wrote:
>> On 20 Dec, 2014, at 8:59, Steve Wills <swills@freebsd.org>
>> wrote:
>> 
>> Author: swills Date: Sat Dec 20 15:59:46 2014 New Revision:
>> 375010 URL: https://svnweb.freebsd.org/changeset/ports/375010 
>> QAT: https://qat.redports.org/buildarchive/r375010/
>> 
>> Log: Make using GitHub releases easier
>> 
>> Differential Revision:	https://reviews.freebsd.org/D1340 With
>> hat:	portmgr
>> 
>> -# -# GitHub files can also be obtained, without the need for any
>> of the above, by doing: -# -# MASTER_SITES=
>> http://github.com/accountname/${PORTNAME}/archive/${PORTVERSION}.tar.gz?dummy=/
>>
>> 
-#
> 
> That shortcut code still works, and it's still simpler than using 
> USE_GITHUB and having to keep track of commit hashes on every
> update. Why remove it?
> 
> The PH says, "If the distribution file comes from a specific
> commit or tag on GitHub for which there is no officially released
> file, [...]". That code block is a way to get it when there IS an 
> officially released file.

Wouldn't you still have to do work to update the distinfo if the
commit hash changes?

Steve