Date: Sun, 21 Dec 2014 17:48:33 +0000 From: Steve Wills <swills@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r375010 - head/Mk Message-ID: <549707F1.4070205@FreeBSD.org> In-Reply-To: <46210F48-0FE2-4B61-AA64-17472B9EAEEB@adamw.org> References: <201412201559.sBKFxl9d088764@svn.freebsd.org> <46210F48-0FE2-4B61-AA64-17472B9EAEEB@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/21/14 15:15, Adam Weinberger wrote: >> On 20 Dec, 2014, at 8:59, Steve Wills <swills@freebsd.org> >> wrote: >> >> Author: swills Date: Sat Dec 20 15:59:46 2014 New Revision: >> 375010 URL: https://svnweb.freebsd.org/changeset/ports/375010 >> QAT: https://qat.redports.org/buildarchive/r375010/ >> >> Log: Make using GitHub releases easier >> >> Differential Revision: https://reviews.freebsd.org/D1340 With >> hat: portmgr >> >> -# -# GitHub files can also be obtained, without the need for any >> of the above, by doing: -# -# MASTER_SITES= >> http://github.com/accountname/${PORTNAME}/archive/${PORTVERSION}.tar.gz?dummy=/ >> >> -# > > That shortcut code still works, and it's still simpler than using > USE_GITHUB and having to keep track of commit hashes on every > update. Why remove it? > > The PH says, "If the distribution file comes from a specific > commit or tag on GitHub for which there is no officially released > file, [...]". That code block is a way to get it when there IS an > officially released file. Wouldn't you still have to do work to update the distinfo if the commit hash changes? Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?549707F1.4070205>