From owner-svn-src-all@freebsd.org Thu Mar 29 01:11:47 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 070EEF5EC34; Thu, 29 Mar 2018 01:11:47 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C1A66DC81; Thu, 29 Mar 2018 01:11:46 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-lf0-f46.google.com with SMTP id o102-v6so6049222lfg.8; Wed, 28 Mar 2018 18:11:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XXe95vZDpk0svKwJ91FeHu1zD3ihGVLHXeh46sPc8OM=; b=bF+AXfqn4W4lxa7R9t8aWBUQNJ3mbt3OFwkWuyJPzQRvCyeeJwzIr1ZSDM4/7kjRRL K1dzCraf0vErwjCvvDmxi3Xqa5IcJd+sj3CAKdRvKYhrX3riTpbIRYLcNN8PwxBt+nvm ASL5lYIQ6k2NBZhvw0/9Y/O8ZLerbRMUHXQ7DFkaJr0xVdJQ02vGWCBySqIf/p2gJXLY ty8jtNo9IEfvak2dK7SSCyXfsHUs4RTg0Vj1pZiyGHdXDkuuYyU9oA2dXw63yoml0Xtx 4N3ItMx7WtgV4qDyCMS3MaAcCR1AmHWgvQqCxI6nMbNmQgtdTWDCWssLa1D6WueHfycg vkFA== X-Gm-Message-State: AElRT7G6LPr6krxhB7oT4uB4nMB+VZaH4YUE5GGTogzb9yDJVKJ4jPhB zWfl7V81KFLC47BshPDYwvBBzmte X-Google-Smtp-Source: AIpwx4+nPohiuUvniPUuio5oD7vzgBrph8E3YQ4OVPS7z3dSbXgZedtj97CFV3fRIwwLnEm1TpVH9Q== X-Received: by 10.46.9.65 with SMTP id 62mr3802365ljj.33.1522285898950; Wed, 28 Mar 2018 18:11:38 -0700 (PDT) Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com. [209.85.215.46]) by smtp.gmail.com with ESMTPSA id 17sm702314ljr.66.2018.03.28.18.11.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Mar 2018 18:11:38 -0700 (PDT) Received: by mail-lf0-f46.google.com with SMTP id e5-v6so6060220lfb.7; Wed, 28 Mar 2018 18:11:38 -0700 (PDT) X-Received: by 2002:a19:7904:: with SMTP id u4-v6mr3929708lfc.129.1522285898729; Wed, 28 Mar 2018 18:11:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.129.90 with HTTP; Wed, 28 Mar 2018 18:11:18 -0700 (PDT) In-Reply-To: References: <201803140319.w2E3JuGP036341@repo.freebsd.org> From: Kyle Evans Date: Wed, 28 Mar 2018 20:11:18 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r330897 - in stable/11: bin/cat bin/chflags bin/chmod bin/cp bin/date bin/dd bin/df bin/domainname bin/echo bin/ed bin/hostname bin/kill bin/ln bin/ls bin/mkdir bin/mv bin/pax bin/ps bi... To: Allan Jude Cc: Oliver Pinter , Eitan Adler , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 01:11:47 -0000 On Wed, Mar 28, 2018 at 8:04 PM, Allan Jude wrote: > On 2018-03-28 14:15, Oliver Pinter wrote: >> Hi! >> >> This part of the MFC is wrong: >> >> https://svnweb.freebsd.org/base/stable/11/sys/sys/random.h?limit_changes=0&r1=330897&r2=330896&pathrev=330897 >> >> Could you please MFC back the other random related changes too? Some >> of them made by cem@. >> >> On 3/14/18, Eitan Adler wrote: >>> Author: eadler >>> Date: Wed Mar 14 03:19:51 2018 >>> New Revision: 330897 >>> URL: https://svnweb.freebsd.org/changeset/base/330897 >>> >>> Log: >>> Partial merge of the SPDX changes >>> >>> These changes are incomplete but are making it difficult >>> to determine what other changes can/should be merged. >>> >>> No objections from: pfg >>> > Am I missing something? If this MFC was supposed to be of the SPDX > license tagging, why does it have any functional changes? > > Especially changes to random(4)? For extra fun, it also had some ARM driver changes that had broken the VERSATILE kernels, as I recall. gonzo@ took care of MFC'ing the other parts needed for those, though. It does make me wonder what else was overlooked, but the commit was large enough that it's not fun to glance over.