From owner-freebsd-ports@FreeBSD.ORG  Wed Aug 23 20:42:45 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: freebsd-ports@freebsd.org
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 74E5A16A4E0
	for <freebsd-ports@freebsd.org>; Wed, 23 Aug 2006 20:42:45 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx24.fluidhosting.com [204.14.89.7])
	by mx1.FreeBSD.org (Postfix) with SMTP id BDFEC43D6B
	for <freebsd-ports@freebsd.org>; Wed, 23 Aug 2006 20:42:43 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 28890 invoked by uid 399); 23 Aug 2006 20:42:42 -0000
Received: from localhost (HELO ?192.168.0.3?) (dougb@dougbarton.us@127.0.0.1)
	by localhost with SMTP; 23 Aug 2006 20:42:42 -0000
Message-ID: <44ECBDC0.7000802@FreeBSD.org>
Date: Wed, 23 Aug 2006 13:42:40 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 1.5.0.5 (X11/20060729)
MIME-Version: 1.0
To: Yar Tikhiy <yar@comp.chem.msu.su>
References: <20060821071036.GA44406@comp.chem.msu.su>
In-Reply-To: <20060821071036.GA44406@comp.chem.msu.su>
X-Enigmail-Version: 0.94.1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-ports@freebsd.org
Subject: Re: A section on gettext for the Porter's Handbook
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Aug 2006 20:42:45 -0000

Yar Tikhiy wrote:
> Hi all,
> 
> I hoped I had learned something about using gettext in ports,
> and felt I should write down a summary.  Here's what came out
> of that -- a proposed section for the Porter's Handbook.  Its
> HTML rendering is available there:
> 
> http://people.freebsd.org/~yar/porters-handbook/using-gettext.html
> 
> Remarks and corrections are welcome.  Thanks!
> 
+.if defined(WITHOUT_NLS)
+CONFIGURE_ARGS+=        --disable-nls
+PLIST_SUB+=             NLS="@comment "
+.else
+USE_GETTEXT=            yes
+CONFIGURE_ENV=          LDFLAGS="-L${LOCALBASE}/lib"
+PLIST_SUB+=             NLS=""
+.endif</programlisting>

Should that be .if !defined(WITHOUT_NLS), and then the outcome of the tests
reversed? The reason being that most authors who would put that in OPTIONS
would default NLS to on.

Otherwise, good stuff. I think that leading people down the right path for
the various knobs is a good thing, even if it seems "obvious" to us old hands.

Doug

-- 

    This .signature sanitized for your protection