From owner-svn-ports-head@freebsd.org  Sat May 21 11:43:58 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 47227B4479B;
 Sat, 21 May 2016 11:43:58 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 2876B1268;
 Sat, 21 May 2016 11:43:58 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 27026122F; Sat, 21 May 2016 11:43:58 +0000 (UTC)
Date: Sat, 21 May 2016 11:43:58 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: marino@freebsd.org
Cc: Ed Maste <emaste@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org>,
 ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r415078 - in head: . Mk
Message-ID: <20160521114358.GC624@FreeBSD.org>
References: <201605121820.u4CIKROJ004026@repo.freebsd.org>
 <20160513160151.GA30219@FreeBSD.org>
 <20160513182837.GF49383@ivaldir.etoilebsd.net>
 <20160513201919.GA48945@FreeBSD.org>
 <CAPyFy2A9L1cCikOrgBAWUo0GTCLJ4EgzqukhobaJp+Zqv7_SpQ@mail.gmail.com>
 <20160519122306.GA24015@FreeBSD.org>
 <20160521112728.GA624@FreeBSD.org>
 <364d3d9f-63ff-18c8-c730-a11c57dc0673@marino.st>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <364d3d9f-63ff-18c8-c730-a11c57dc0673@marino.st>
User-Agent: Mutt/1.6.0 (2016-04-01)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 May 2016 11:43:58 -0000

On Sat, May 21, 2016 at 01:33:36PM +0200, John Marino wrote:
> On 5/21/2016 1:27 PM, Alexey Dokuchaev wrote:
> > On Thu, May 19, 2016 at 12:23:06PM +0000, Alexey Dokuchaev wrote:
> >> ...
> >> I'm still not convinced though, sorry.  Ports tree can be obtained by
> >> a number of means, but this new ugly TIMESTAMP thingy is added for a
> >> very specific usecase, and there should be no problem to require that
> >> for that particular usecase, exported ports tree must have its files'
> >> mtimes correctly set.  (If svn/git/hg are not setting right mtimes on
> >> export, they should be fixed.)  It looks more like quick'n'dirty hack
> >> rather than thoroughly thought-out solution.
> >
> > Given lack of replies, I guess I'd have to elaborate a bit on problems with
> > TIMESTAMP and why I'm against it.
> >
> > 1. It does not line up with distinfo format...
> > 2. It is not needed even if ports repo is obtained as tarball...
> 
> Maybe it could/should be implemented as a makefile variable instead?
> 
> e.g. REP_TIMESTAMP=
> 
> Just a suggestion.  I don't disagree with you.

While still hackish, it's a *lot* less ugly and bogus as tainting distinfo.
(New variable in Makefile is OK because that's what Makefiles are made of:
variables, targets, and recipes.  Adding TIMESTAMP to distinfo is NOT OK
because distinfo describes port's distfiles in a form of FOO(), BAR(), ...
values per each distfile.)

./danfe