From owner-freebsd-arm@freebsd.org Sat Jan 9 15:08:41 2021 Return-Path: Delivered-To: freebsd-arm@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C4D034D810E for ; Sat, 9 Jan 2021 15:08:41 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DCjzF0YkBz3LMp for ; Sat, 9 Jan 2021 15:08:40 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-il1-x12d.google.com with SMTP id r17so13417711ilo.11 for ; Sat, 09 Jan 2021 07:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uiUqotblq++p4KuYQRftIY9eHygL1UR5/VuGHaLy/0U=; b=S6nENuYxyBsDZSndlfLXmJP0lZhbzLLwijxH9Nk07LnzrjtRcPUITRUGgxvcoqZ8bz QObsYpUFUcV/T2QQKEYVvz2Vw08K1+nJIqomrGogo8Ic5dFk+saDm/0YPZXQZf9K05P8 rZ74Z7m2mTVmzHAZbX0FQLvyGxqIgWGwOZMp+KOMh/H+3kPsmPPFLtF3uguD1+4EM6Xy kTMOFjrq94Y+KENDRg7pgNskHp9vaKbwK3YVcaCLhondlYGNcSG1gcTwMfJLkm4CwFRA eNZuZKTAZHLWkuSbjOpaNuVdcv95GgmHiAgQvBfCD4OlUS9FvbdEMxe/aM80Nqbgw5lE z5/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=uiUqotblq++p4KuYQRftIY9eHygL1UR5/VuGHaLy/0U=; b=k2ZKMU/IscLsPkwQKJIfR5F9VUCHVs9pFLrsxykOoPsyeVu11xAs1nmwvEyJp2sxpU YD65TKXzU5XKubeCq3c0hDuB4dRY2YMwMVbv6LZHlSQgD1O01dAFrlqH8txVHJl1KCBZ 64/FvUMYUpoMireQDxe0cGsZ8bHzZbPeHc9uPG63j1tXMdpcMLQabvo1kRB4DE204uWT BStOdnV1Uxp81K0v9N2mTDdke6DTcsHwVJlzLWaAEkkvOpVd1R3ias4AoYogqNyjiVl0 B/eLiSCZQYXdeAja47hsJ6d+WLb0su5uyDS7lnGWc/ymZGjCO13PF360at6Ek5Kp4PBY LAhQ== X-Gm-Message-State: AOAM531glOKS66xts9C9Ydo8SXfUqmHV2IZXMyWp+/ikpSkv1mt36prC iWR8JJPT2dw3O73LClFdmsI= X-Google-Smtp-Source: ABdhPJzEV/8iCEJ7nUuSgq7MXR1xloyQbFY54bexgee4YJku88CxA1ndWf47pTbxTTuhqcWYqF84eA== X-Received: by 2002:a92:da0f:: with SMTP id z15mr1038920ilm.287.1610204919788; Sat, 09 Jan 2021 07:08:39 -0800 (PST) Received: from raichu ([142.126.164.150]) by smtp.gmail.com with ESMTPSA id w9sm9609615ilq.43.2021.01.09.07.08.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jan 2021 07:08:39 -0800 (PST) Sender: Mark Johnston Date: Sat, 9 Jan 2021 10:08:37 -0500 From: Mark Johnston To: Andrei Martin Cc: freebsd-arm@freebsd.org Subject: Re: neta device generates kernel panic Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4DCjzF0YkBz3LMp X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=S6nENuYx; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::12d as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.69 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.99)[-0.992]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::12d:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arm@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::12d:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::12d:from]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-arm] X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jan 2021 15:08:41 -0000 On Sat, Jan 09, 2021 at 04:07:50PM +0200, Andrei Martin wrote: > Hello, > > While trying to run the FreeBSD on EspressoBin (arm64) a kernel panic > appeared in the neta device. > The following function call[1] was the one generating this behaviour. It > says that the SC mutex > is not owned. My solution was to add the lock/unlock operations, as follows: > *mvneta_sc_lock(sc);* > *mvneta_clear_mib(sc);* > *mvneta_sc_unlock(sc);* > > *and it works fine.* Hi Andrei, Sorry for the breakage, after making some modifications to the patch I only retested with GENERIC-NODEBUG. I pushed a fix to main. > > *Also, reading the patch[2], found that `mvneta_clear_mib` does some new > operations (counter_pdfc = counter_pofc = counter_watchdog = 0) than just > clearing MIB counter registers. I do not know if it was intended but it's > worth mentioning.* That was intentional. > > [1] > https://github.com/freebsd/freebsd-src/blob/main/sys/dev/neta/if_mvneta.c#L1193 > [2] > https://github.com/freebsd/freebsd-src/commit/caf552a607191ffc798e3edb697ae99d5b15711a > > Andrei > _______________________________________________ > freebsd-arm@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org"