From owner-svn-src-all@freebsd.org Fri Apr 26 16:21:47 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8BBF41597D7E; Fri, 26 Apr 2019 16:21:47 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8A70772FB2; Fri, 26 Apr 2019 16:21:46 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-it1-x144.google.com with SMTP id y134so6745103itc.5; Fri, 26 Apr 2019 09:21:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=wdcBadMHDbWgfGXvs+ul7v4Kefxqr6fSZzmKD/ZUP8g=; b=Gpc/J4pUbKIUBu3LV+TtoRyHZGyrsb+tXxtLbE9plqzx6E2Lq9nokUtYglg2v4t2mV WlckT3lKCMPLePL5tn2Z1RZHyS/QXwk73qljmAIatrU7MfOm7pheeXrBFUNogBL3Mm0S wdi27uu/pnHniWStsbRJHF40S/z0OkNtBrGYRXzpooqN/E+rAZOeS9nMlNE4oYBv1dfG Oyhv3/GorFBFQGklq9MFLMv51lZI1OnBR27/9h9CfbeHUm5W4ipoaOtMJfnWKN4J0E1E J0EscBRYBD1BsdaXp3G+D96HktLRjqI8iH9rBHXxWRwA9xHU1UGOOLRr9HkgxDEqYeyw /6WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :in-reply-to:references:organization:mime-version :content-transfer-encoding; bh=wdcBadMHDbWgfGXvs+ul7v4Kefxqr6fSZzmKD/ZUP8g=; b=M71H5q7/1qgjJpI6ii7Xe9JpbOjhOgbC1YYveFiCAk3DNxAAHRxPT4igXc0nJH7gGU pQpAw72Vty9ICkZPc0XOgXENcrp8oj7N9Pe2h5Fowh8OcOlTKPdl25ctw5Wk/tI8vLmo f23MJtZGflgyuVk0E/yVRUw8Re3leE7L1LsuYy7+EbvFHm67c4ySLV6Bj8EKb/xbddWh dGIDjSDTd+lSl7KBjJB4ijT0Z8Fbmk3HbHnsIvogoC/GBfnbQFXYQg55tn6CI+zvcYnz AcoeZRzVXZ3PdJY6xriKChnvZueuWKfuQHUisOFb1a7dhDT6OvpkTiET5zuCcOIZERhM ueDw== X-Gm-Message-State: APjAAAWKPdpePDY89k77olzedKZXmYr78TfG3qqR5XZZ91pHkhTK6ygC tpv6IfWNWW9ZzlZpkP1LZd777aSD X-Google-Smtp-Source: APXvYqxMSxwIl8eiwVEVV9kbJjtIWoOQ9P1B+tJVLkdPD3xqb1Ss/0FpKcJoU7mKh0aHT91JoJUTQQ== X-Received: by 2002:a24:7294:: with SMTP id x142mr8854179itc.7.1556295705135; Fri, 26 Apr 2019 09:21:45 -0700 (PDT) Received: from titan.knownspace (173-25-245-129.client.mchsi.com. [173.25.245.129]) by smtp.gmail.com with ESMTPSA id b8sm12585336itb.20.2019.04.26.09.21.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Apr 2019 09:21:44 -0700 (PDT) Sender: Justin Hibbits Date: Fri, 26 Apr 2019 11:21:41 -0500 From: Justin Hibbits To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346588 - head/lib/libc/powerpc64/string Message-ID: <20190426112141.78632e17@titan.knownspace> In-Reply-To: <20190423102442.GA86961@FreeBSD.org> References: <201904230253.x3N2rrrh041288@repo.freebsd.org> <20190423102442.GA86961@FreeBSD.org> Organization: FreeBSD X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; powerpc64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8A70772FB2 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Gpc/J4pU; spf=pass (mx1.freebsd.org: domain of chmeeedalf@gmail.com designates 2607:f8b0:4864:20::144 as permitted sender) smtp.mailfrom=chmeeedalf@gmail.com X-Spamd-Result: default: False [-3.80 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[FreeBSD.org]; TO_DN_SOME(0.00)[]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-0.80)[ip: (1.49), ipnet: 2607:f8b0::/32(-3.16), asn: 15169(-2.26), country: US(-0.06)]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[4.4.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.79)[-0.788,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; FORGED_SENDER(0.30)[jhibbits@FreeBSD.org,chmeeedalf@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[jhibbits@FreeBSD.org,chmeeedalf@gmail.com] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2019 16:21:47 -0000 On Tue, 23 Apr 2019 10:24:42 +0000 Alexey Dokuchaev wrote: > On Tue, Apr 23, 2019 at 02:53:53AM +0000, Justin Hibbits wrote: > > New Revision: 346588 > > URL: https://svnweb.freebsd.org/changeset/base/346588 > > > > Log: > > powerpc64: Rewrite strcmp in asm to take advantage of word size > > ... > > Some performance gain rates between the current and the optimized > > solution: > > > > String size (bytes) Gain rate > > <=8 0.59% > > <=16 1.92% > > 32 3.02% > > 64 5.60% > > 128 10.16% > > 256 18.05% > > 512 30.18% > > 1024 42.82% > > Nice! This should help to speed up buildworld quite a bit. Would it > be feasible to patch ppc32 in a similar fashion? Thanks, > > ./danfe This actually uses 'cmpb' which is only available on PowerISA 2.05+, so I'll need to pull it out for now, and re-enable it once we have ifuncs. As it stands, this commit broke the G5 and POWER4/POWER5. - Justin