Date: Sat, 23 Dec 2006 03:10:22 GMT From: Stefan Sperling <freebsd-ports@stsp.in-berlin.de> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/107125: [PATCH] emulators%2Fzsnes: update to 1.5.0 Message-ID: <200612230310.kBN3AMgB001330@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/107125; it has been noted by GNATS.
From: Stefan Sperling <freebsd-ports@stsp.in-berlin.de>
To: bug-followup@FreeBSD.org
Cc:
Subject: Re: ports/107125: [PATCH] emulators%2Fzsnes: update to 1.5.0
Date: Sat, 23 Dec 2006 03:48:23 +0100
--CE+1k2dSO48ffgeK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
> +pre-everything::
> + @${GREP} "#define ZLIB_VERSION" /usr/include/zlib.h | \
> + ${AWK} '{print substr($$3, 2, length($$3) - 2)}' | \
> + ${SED} 's/\./ /g' | \
> + ${AWK} '{printf("%02d%02d%02d", $$1, $$2, $$3)}' | \
> + ${AWK} '{if ($$1 > 010202) {exit 0} else {exit 1}}'
> + @if [ 0 -ne $$? ] ; then \
> + @${ECHO} "This port requires zlib >=3D 1.2.3" ; \
> + @${FALSE} ; \
> + fi
The pre-everything target causes the following here:
[stsp@ted /usr/ports/emulators/zsnes]$ make
*** Error code 1
Stop in /usr/ports/emulators/zsnes.
It gives users no clue as to what is going on unless they
look into the Makefile.
When I change it to:
pre-everything::
@${GREP} "#define ZLIB_VERSION" /usr/include/zlib.h | \
${AWK} '{print substr($$3, 2, length($$3) - 2)}' | \
${SED} 's/\./ /g' | \
${AWK} '{printf("%02d%02d%02d", $$1, $$2, $$3)}' | \
${AWK} '{if ($$1 > 010202) {exit 0} else {exit 1}}' \
|| (${ECHO} "This port requires zlib >=3D 1.2.3"; ${FALSE};)
it prints the message correctly:
[stsp@ted /usr/ports/emulators/zsnes]$ make
This port requires zlib >=3D 1.2.3
*** Error code 1
Stop in /usr/ports/emulators/zsnes.
I have a 6.1 system only. According to CVS log, zlib-1.2.3 is in 6.2.
I cannot test this properly until I've upgraded to 6.2.
Apart from the small error in the pre-everything target described
above, the patch looks very good.
--=20
stefan
http://stsp.in-berlin.de PGP Key: 0xF59D25F0
--CE+1k2dSO48ffgeK
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)
iD4DBQFFjJj35dMCc/WdJfARAkaWAJwMmj/mwoDduEeKf2LDQ4LhH5e5VwCXQLzd
lspdUA8F+L58UYhvAuJQ2A==
=B3W2
-----END PGP SIGNATURE-----
--CE+1k2dSO48ffgeK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612230310.kBN3AMgB001330>