From owner-cvs-src@FreeBSD.ORG  Wed May 28 14:27:41 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E586137B401
	for <cvs-src@FreeBSD.org>; Wed, 28 May 2003 14:27:41 -0700 (PDT)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 70D3B43F75
	for <cvs-src@FreeBSD.org>; Wed, 28 May 2003 14:27:41 -0700 (PDT)
	(envelope-from nate@rootlabs.com)
Received: (qmail 8621 invoked by uid 1000); 28 May 2003 21:27:42 -0000
Date: Wed, 28 May 2003 14:27:42 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Mark Linimon <linimon@lonesome.com>
In-Reply-To: <200305281558.51481.linimon@lonesome.com>
Message-ID: <20030528142349.I8609@root.org>
References: <200305271919.h4RJJ5kd039145@repoman.freebsd.org>
 <xzpznl7c7zh.fsf@flood.ping.uio.no> <20030528102708.J8183@root.org>
 <200305281558.51481.linimon@lonesome.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/contrib/dev/acpica - Imported sources
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 May 2003 21:27:42 -0000

On Wed, 28 May 2003, Mark Linimon wrote:
> > I'll do more compile testing in the future but it is painful since my
> > system takes so long to build.
>
> Nate, you may feel I'm picking on you specifically, but I'm not.
> I'm saying that it doesn't make sense to use the tinderboxen
> to be doing compile testing after a freeze has supposedly gone
> into effect.  After a freeze goes into effect, IMVVHO the only
> things that should go into the tree are things that multiple people
> have already beat the (*&^(*&^ out of and thus have almost no risk
> and almost certain gain.

Um, the build breakage was a static function which became unstaticized
without a prototype.  The "fix" is to add static back to the function.
The functionality behind the patch (the rest of it) HAD been run-time
tested and fixed known problems for us and had been in the NetBSD tree for
a few weeks.

It so happens that spare time to work on FreeBSD seems to work in relation
to the inverse of release cycles.  :)  So mea culpa, etc., will try harder
next time.

-Nate