From owner-freebsd-audit@FreeBSD.ORG  Tue May 13 00:34:15 2003
Return-Path: <owner-freebsd-audit@FreeBSD.ORG>
Delivered-To: freebsd-audit@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9DB9537B401
	for <audit@freebsd.org>; Tue, 13 May 2003 00:34:15 -0700 (PDT)
Received: from numeri.campus.luth.se (numeri.campus.luth.se [130.240.197.103])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5DEA743F93
	for <audit@freebsd.org>; Tue, 13 May 2003 00:34:14 -0700 (PDT)
	(envelope-from k@numeri.campus.luth.se)
Received: from numeri.campus.luth.se (localhost [127.0.0.1])
	by numeri.campus.luth.se (8.12.9/8.12.9) with ESMTP id h4D7YBdZ096952;
	Tue, 13 May 2003 09:34:11 +0200 (CEST)
	(envelope-from k@numeri.campus.luth.se)
Received: (from k@localhost)
	by numeri.campus.luth.se (8.12.9/8.12.9/Submit) id h4D7YB5V096951;
	Tue, 13 May 2003 09:34:11 +0200 (CEST)
Date: Tue, 13 May 2003 09:34:11 +0200
From: Johan Karlsson <johan@freebsd.org>
To: Max Khon <fjoe@iclub.nsu.ru>
Message-ID: <20030513073411.GA96739@numeri.campus.luth.se>
References: <20030512155847.GA5689@iclub.nsu.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030512155847.GA5689@iclub.nsu.ru>
User-Agent: Mutt/1.4i
cc: FreeBSD-audit <audit@freebsd.org>
Subject: Re: realpath(3)
X-BeenThere: freebsd-audit@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: FreeBSD Security Audit <freebsd-audit.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-audit>,
	<mailto:freebsd-audit-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-audit>
List-Post: <mailto:freebsd-audit@freebsd.org>
List-Help: <mailto:freebsd-audit-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-audit>,
	<mailto:freebsd-audit-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 May 2003 07:34:15 -0000

Hi

On Mon, May 12, 2003 at 22:58 (+0700) +0000, Max Khon wrote:
> hi, there!
> 
> I am going to MFC realpath(3) and would like to get another round of
> review before MFC. Please look at
> 
> http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/stdlib/realpath.c?rev=1.19&content-type=text/x-cvsweb-markup

There are three realy minor things found by trying to make the code 
WARNS=6 clean.

The comparisions on line 94 and line 173 comapares unsigned versus
signed. 

The variable 'symlink' shadows a function from unistd.h
and should be chnaged.

Thanks for doing the MFC.

/Johan K


> 
> /fjoe
> 
> _______________________________________________
> freebsd-audit@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-audit
> To unsubscribe, send any mail to "freebsd-audit-unsubscribe@freebsd.org"

-- 
Johan Karlsson		mailto:johan@FreeBSD.org