From owner-freebsd-gnome Sat Feb 2 20:48:54 2002 Delivered-To: freebsd-gnome@freebsd.org Received: from creme-brulee.marcuscom.com (rdu57-28-046.nc.rr.com [66.57.28.46]) by hub.freebsd.org (Postfix) with ESMTP id F2C8A37B402 for ; Sat, 2 Feb 2002 20:48:51 -0800 (PST) Received: from shumai.marcuscom.com (marcus@shumai.marcuscom.com [192.168.1.4]) by creme-brulee.marcuscom.com (8.11.6/8.11.6) with ESMTP id g134m3m55072; Sat, 2 Feb 2002 23:48:04 -0500 (EST) (envelope-from marcus@marcuscom.com) Subject: Re: Missing continue in patch-ltmain.sh From: Joe Clarke To: Maxim Sobolev Cc: gnome@FreeBSD.ORG In-Reply-To: <1012694178.927.33.camel@notebook> References: <1012689198.65931.43.camel@shumai.marcuscom.com> <1012694178.927.33.camel@notebook> Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Evolution/1.0.1 Date: 02 Feb 2002 23:49:19 -0500 Message-Id: <1012711759.94552.10.camel@shumai.marcuscom.com> Mime-Version: 1.0 Sender: owner-freebsd-gnome@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 2002-02-02 at 18:56, Maxim Sobolev wrote: > On Sun, 2002-02-03 at 00:33, Joe Clarke wrote: > > Maxim, the recent changes you made to patch-ltmain.sh in a few ports > > have had a bad effect on -stable. These ports will refuse to link due > > to -pthread missing from the linker arguments. The problem is the > > continue you added after compiler_flags="$compiler_flags -pthread", > > compiler_flags gets overwritten. I think the continue should be left > > out when setting compiler_flags. > > > > The problem affects glade and mrproject at least. It looks like any > > port that contains an application will run into this problem in the > > linking phase. Therefore, gnomevfs is not affected. > > Grrr, it seems that libtool doesn't use compiler_flags when linking > executable. Attached please find updated version of patch-ltmain.sh > which should fix the issue. Unfortunately currently I do not have a 4.x > machine to test this patch on, so that it would be really nice if you > could test it with failing ports (mrproject and glade) and let me know > ASAP. This patch works just fine. I'm wondering, though, why we need this block at all? -pthread seems to be passed through to libtool just fine in all the ports I've seen. In any event, this fixes ports/34512. Thanks. Joe > > Thanks! > > -Maxim > P.S. As the patch-ltmain.sh growth larger and larger I'm more and more > tempted to take several days and rewrite libtool in C specifically for > FreeBSD. > > ---- > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-gnome" in the body of the message