Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 Sep 2011 18:23:58 +0000 (UTC)
From:      Dag-Erling Smorgrav <des@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r225810 - head/lib/libfetch
Message-ID:  <201109271823.p8RINwQ3035625@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: des
Date: Tue Sep 27 18:23:58 2011
New Revision: 225810
URL: http://svn.freebsd.org/changeset/base/225810

Log:
  Long overdue: make passive mode the default for ftp.

Modified:
  head/lib/libfetch/ftp.c

Modified: head/lib/libfetch/ftp.c
==============================================================================
--- head/lib/libfetch/ftp.c	Tue Sep 27 18:14:04 2011	(r225809)
+++ head/lib/libfetch/ftp.c	Tue Sep 27 18:23:58 2011	(r225810)
@@ -638,8 +638,8 @@ ftp_transfer(conn_t *conn, const char *o
 
 	/* passive mode */
 	if (!pasv)
-		pasv = ((s = getenv("FTP_PASSIVE_MODE")) != NULL &&
-		    strncasecmp(s, "no", 2) != 0);
+		pasv = ((s = getenv("FTP_PASSIVE_MODE")) == NULL ||
+		    strncasecmp(s, "no", 2) == 0);
 
 	/* isolate filename */
 	filename = ftp_filename(file, &filenamelen, &type);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201109271823.p8RINwQ3035625>