From nobody Thu Jan 29 19:36:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f28XV5bw2z6PpTk for ; Thu, 29 Jan 2026 19:36:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f28XV3p6Mz3tm9 for ; Thu, 29 Jan 2026 19:36:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769715402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2+Q33cpmCuZeEaOY53p4KdpvQR2n+Gf6sieL7TPYUVY=; b=up1vgNkctu9iNKDnjIAV9hRLzinENlFRKffAivE1yo1C8NiunVAFj/EzLMQJMsFcHfYIHq 6XAJ7suxk00vu1oMvrbdlQQXke0DXoJfshRY8Y1ORkyYCuYmhkPELEYURdqw1ZFf6pWtGr 3/sp/WQLrQMasX/Wk+aowhcgl8ke+gscj5P7782H3GVT44CAiVPBGyEhusv1svSM4CnAen cGQMWvluK3wOo8q22WjuDT4ZuVA26f1GEsKC+zF84SggsHuaS7wkXBB0IteKQDdAuEJ4RD k+Al3x10C2+A3UeQThxI4gZB99AznULHHuf6z4ACLH4CtdcvGVvGtNCBSBIbeQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769715402; a=rsa-sha256; cv=none; b=sv6Wh7PYi1XWSDsLHvCW55POI014C+DauwOac8MnXsjXEnlGmZds4IHCKjFNj4nk3vS6gg ty1Mv+DR3LWKgF6AfECMl3O2W+XHJPqRI+dQInYJO45gGTK251T97k+ee4yXD35xRtIwqz Z0g0zDVl/Tbuz6qmte11oIrSsry9JmHDQlBvadHhLws8RTOGgBsDObBQvmHUA3CkxNJP8o ixNSrcVwZEevD6CmzUwWRLyx94YVBqfOEDllg8Qlz8DIHKYngI563oSSOU0gUT+zBeyxV8 iB9ZocDE/d4an2s87R4+/y07Ujapg7NcBAdO7GVWuLmjgWisUVRSTJOYq/0G1g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769715402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2+Q33cpmCuZeEaOY53p4KdpvQR2n+Gf6sieL7TPYUVY=; b=OYm0n5UBe8OOAKKjnXGrN1X7FRjx0t7q1Crk3IRrkCj5yyzY2K7zx5sFOzKudh3yEyJMOr yxV6J4iNvR3kxlRxDIpEw96KqZRkvVqq5CZ/tIoV+a3NLsI25L0Z5pHIXgGh/sfIJJrz7l sp/nF83zJBeLbgVnl6iKlwAuElBYWb4I5Vf1tW7Lb5RHzFLcb+RBj9oz+TBnngGH46ZRlH 9DgPljv+rR4dbhp7VzTqYJVgvL75ji7ZXj4BcWzaH1yCLJci2bocKA4NQpSHu7Xkdb4DVl nPVLitQWxx1QUw0pzPyJvRpI09LDQCQokn95GKDxZBpocqsc2w5CqyIE/exI9w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f28XV2lr7zs0B for ; Thu, 29 Jan 2026 19:36:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id dbf3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Jan 2026 19:36:42 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Bjoern A. Zeeb Subject: git: 4b32fdb4a614 - main - lindebugfs: check that name is set as otherwise pfs_alloc_node_flags() panics List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4b32fdb4a614de602d288ac5a414cb43e9f2163e Auto-Submitted: auto-generated Date: Thu, 29 Jan 2026 19:36:42 +0000 Message-Id: <697bb6ca.dbf3.3767cf26@gitrepo.freebsd.org> The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=4b32fdb4a614de602d288ac5a414cb43e9f2163e commit 4b32fdb4a614de602d288ac5a414cb43e9f2163e Author: Bjoern A. Zeeb AuthorDate: 2026-01-29 11:16:50 +0000 Commit: Bjoern A. Zeeb CommitDate: 2026-01-29 19:35:23 +0000 lindebugfs: check that name is set as otherwise pfs_alloc_node_flags() panics I have hit the case multiple times that some LinuxKPI field may not be set during driver bringup and lindebugfs would cause a panic. The backtrace goes like: strlen() at strlen+0x54 pfs_create_dir() at pfs_create_dir+0x41 debugfs_create_dir() at debugfs_create_dir+0xa1 ... While the problem is clearly in LinuxKPI or the driver, we likely should at least add an assert to pfs_create_dir() if name is NULL like we have for pfs_add_node() but for lindebugfs at least make this a graceful error and continue without creating the dir instead of panicing. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D54944 --- sys/compat/lindebugfs/lindebugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/compat/lindebugfs/lindebugfs.c b/sys/compat/lindebugfs/lindebugfs.c index 8cddc6f390bc..857546f61e55 100644 --- a/sys/compat/lindebugfs/lindebugfs.c +++ b/sys/compat/lindebugfs/lindebugfs.c @@ -272,6 +272,9 @@ debugfs_create_dir(const char *name, struct dentry *parent) struct dentry *dnode; struct pfs_node *pnode; + if (name == NULL) + return (NULL); + dm = malloc(sizeof(*dm), M_DFSINT, M_NOWAIT | M_ZERO); if (dm == NULL) return (NULL);