From owner-svn-src-all@freebsd.org Wed May 18 17:11:21 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 862ADB4131D for ; Wed, 18 May 2016 17:11:21 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5988811F9 for ; Wed, 18 May 2016 17:11:21 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: by mail-io0-x22d.google.com with SMTP id 190so73680633iow.1 for ; Wed, 18 May 2016 10:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=clockworksquid.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=T7r2laSXJo0CCFj8+kTRXwHbh8KXZgS8bHEUAkf6igo=; b=ZiTC6mnktLrjoXAQlUbVoU9s1O9o7KQyAaSgFgb0zCh79o/PMTVoqyDXCNCtas39Rb IxNCIMy3YhX0UJkQsaie//WFpZxJ3frZQJL8IGJeLwTRgemRDDJ+KvoXT9MWf473C1SL T96LVXO+dMwJi0bK5I5Zzw05Snfvxt89IHQ8o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=T7r2laSXJo0CCFj8+kTRXwHbh8KXZgS8bHEUAkf6igo=; b=VgUlgZETHiIN2oTuf6UsdG/93VW4dKTxXz/AaPWp5Mxy+67MuyzhAljwpA3LKD80MS VL4k5jfbs0J3maOEvJUPc/xL85DzDOotbJ4x9CPFcM5vL3Sfs8ger0FdO3mj226RHjHt nEDue+7P6KYpNoLxXUpxeLjq3QJ9ODzBiQa/6dzwpibsoYrM40MG0CR0R5Z9HhIMPz72 sWbM72GGhkscqI9kv9RS858b1qjPsphuRIeJnF3l38ex050i+kYOMSexurbAWaRXrJXh BKWQ3j35/OhtHIsjselPwM72yZMfF/HO+fjA3XI9XZ0ioP6Qq4TX3p/mtL54p6TxAb16 /pWg== X-Gm-Message-State: AOPr4FUh/BNc/NFRlMEVeegLmiq/VXNGF9YT1j/YDZ/7vIgXBbUSCxJU/4U5WwS2Podi5qFK4Y99E+hSQMsqPw== X-Received: by 10.36.115.76 with SMTP id y73mr18950020itb.63.1463591480677; Wed, 18 May 2016 10:11:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.36.68 with HTTP; Wed, 18 May 2016 10:11:01 -0700 (PDT) In-Reply-To: <20160518114134.7a32e69e@zhabar.knownspace> References: <201605181545.u4IFjCKD030751@repo.freebsd.org> <20160518105033.1eae7432@zhabar.knownspace> <7EC6D845-E9EE-4D9E-988B-D433526BAAB1@yahoo.com> <20160518114134.7a32e69e@zhabar.knownspace> From: Juli Mallett Date: Wed, 18 May 2016 10:11:01 -0700 Message-ID: Subject: Re: svn commit: r300154 - head/sys/net To: Justin Hibbits Cc: Scott Long , Warner Losh , Scott Long , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2016 17:11:21 -0000 On Wed, May 18, 2016 at 9:41 AM, Justin Hibbits wrote: > #if (defined(__powerpc__) && !defined(__powerpc64__)) || > (defined(__mips__) && !defined(__mips64__)) > > should work. Depending on what the point of this is on MIPS, it is probably also inadequate. I believe you want a MIPS ABI check, as we can support 64-bit atomics with n32 and n64 ABIs, so !defined(__mips_n32) && !defined(__mips_n64).