From owner-freebsd-current@freebsd.org Fri Apr 24 11:23:04 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E53792AFFCB for ; Fri, 24 Apr 2020 11:23:04 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from smtprelay03.ispgateway.de (smtprelay03.ispgateway.de [80.67.29.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 497sGw1Fv4z4Bkr; Fri, 24 Apr 2020 11:23:03 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from [84.168.155.34] (helo=fabiankeil.de) by smtprelay03.ispgateway.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1jRwQ9-0006wd-Hg; Fri, 24 Apr 2020 13:23:01 +0200 Date: Fri, 24 Apr 2020 13:21:54 +0200 From: Fabian Keil To: Xin LI Cc: Johan Hendriks , FreeBSD Current , Brooks Davis , "M. Warner Losh" , Glen Barber , Bryan Drewery , Ed Maste , Brad Davis Subject: Re: Ordering of files in zoneinfo Message-ID: <20200424132144.7b0bb922@fabiankeil.de> In-Reply-To: References: <202004171047.03HAlFk6050161@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Df-Sender: Nzc1MDY3 X-Rspamd-Queue-Id: 497sGw1Fv4z4Bkr X-Spamd-Bar: +++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd-listen@fabiankeil.de has no SPF policy when checking 80.67.29.28) smtp.mailfrom=freebsd-listen@fabiankeil.de X-Spamd-Result: default: False [3.47 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[28.29.67.80.rep.mailspike.net : 127.0.0.18]; TO_DN_ALL(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; FREEMAIL_TO(0.00)[gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[34.155.168.84.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; IP_SCORE(0.76)[ipnet: 80.67.16.0/20(1.14), asn: 8972(2.70), country: DE(-0.02)]; R_DKIM_NA(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[28.29.67.80.list.dnswl.org : 127.0.5.1]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:8972, ipnet:80.67.16.0/20, country:DE]; ARC_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[fabiankeil.de]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.92)[0.918,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(0.99)[0.986,0]; R_SPF_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_CC(0.00)[gmail.com] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 11:23:05 -0000 Xin LI wrote: > I have took a look at the change history, it seems that the find > operation was introduced in r245265 > (brooks@, > to support packaged base) and sort was initially implemented as find -s > in r289451 > (ngie@, > to make METALOG reproducible) then as sort in r328958 > (imp@, > for portability). > > I wonder if we could drop the sort and replace ${TZS} in line 100 with > ${TZS:O} instead? Makes sense to me. > By the way, looking at > https://github.com/freebsd/pkg/blob/master/libpkg/metalog.c , I wonder if > the sort should really happen in pkg(8) instead? Currently the METALOG is also used when creating the tarballs so sorting only in pkg would be insufficient as long as tarballs are still supported. Fabian