From owner-freebsd-cvsweb@FreeBSD.ORG Sat May 7 18:12:31 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C442316A4DB for ; Sat, 7 May 2005 18:12:31 +0000 (GMT) Received: from smtp2.pp.htv.fi (smtp2.pp.htv.fi [213.243.153.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8070143D5F for ; Sat, 7 May 2005 18:12:31 +0000 (GMT) (envelope-from scop@FreeBSD.org) Received: from cs78131082.pp.htv.fi (cs78131082.pp.htv.fi [62.78.131.82]) by smtp2.pp.htv.fi (Postfix) with ESMTP id F082E296C36 for ; Sat, 7 May 2005 21:12:29 +0300 (EEST) From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: freebsd-cvsweb@freebsd.org In-Reply-To: <3bccd73d050506093958f6c0d2@mail.gmail.com> References: <3bccd73d050506093958f6c0d2@mail.gmail.com> Content-Type: text/plain Organization: FreeBSD Date: Sat, 07 May 2005 21:12:29 +0300 Message-Id: <1115489549.4682.0.camel@bobcat.mine.nu> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-4) Content-Transfer-Encoding: 7bit Subject: Re: Log view diff line X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 May 2005 18:12:31 -0000 On Fri, 2005-05-06 at 09:39 -0700, Jerry Nairn wrote: > > Thoughts about the attached patch? It uses a semicolon for separating > > the diff link "categories", moves the "to" to be only at the beginning > > of the line, and adds parens around the displayed revision numbers. I'm > > not sure if the parens add any value though. > > If it were my choice, I would not add the parens around the revision > number, but it's not anything I feel strongly about. > I like the other changes. Ok, committed without the parens. Thanks again for the feedback.