From owner-freebsd-current@FreeBSD.ORG Tue Aug 26 19:29:02 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8C2DDD3B; Tue, 26 Aug 2014 19:29:02 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 21BAF3F58; Tue, 26 Aug 2014 19:29:02 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 1B9F7B98D; Tue, 26 Aug 2014 15:29:01 -0400 (EDT) From: John Baldwin To: Alan Somers Subject: Re: [PATCH] Packet loss when 'control' messages are present with large data (sendmsg(2)) Date: Tue, 26 Aug 2014 15:15:31 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; ) References: <522300E3.6050303@rawbw.com> <2204059.7tqSNWvxzC@ralph.baldwin.cx> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <201408261515.32146.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 26 Aug 2014 15:29:01 -0400 (EDT) Cc: Harald Schmalzbauer , FreeBSD CURRENT , "net@freebsd.org" , current@freebsd.org, Yuri X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2014 19:29:02 -0000 On Tuesday, August 26, 2014 11:05:12 am Alan Somers wrote: > On Mon, Aug 25, 2014 at 1:52 PM, John Baldwin wrote: > > On Friday, August 22, 2014 01:34:28 PM Harald Schmalzbauer wrote: > >> Bez=C3=BCglich Yuri's Nachricht vom 02.09.2013 06:54 (localtime): > >> > Please check in this patch: > >> > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D181741 > >> > Please MFC into 9.X > >> > > >> > Description of the problem is within PR. > >> > > >> > Thanks, > >> > Yuri > >> > >> Hello, > >> > >> I guess this fix should make it into 10.1. > >> Can someone check please? > > > > A fix has to make into HEAD first. I've cc'd Alan who responded to the= bug. > > Alan, note that glebius@ already committed the test case to HEAD a whil= e ago. >=20 > First, Gleb's testcase needs to be converted to ATF. This would be a > good exercise for anybody who's new to ATF and wants some practice. > Anybody interested? While that would be nice, I don't know that it's quite fair to require the test to be converted before working on a possible fix. The existing test doesn't seem that hard to run by hand: % cd work/freebsd/head/tools/regression/sockets/unix_passfd/ % make =2E.. % > ./unix_passfd=20 beginning test1-simplesendfd test1-simplesendfd passed =2E.. beginning test8-rigths+creds+payload unix_passfd: test8-rigths+creds+payload: recvmsg: 24 bytes received I only say this because in the bug followup you seemed to have described a possible solution so it seems that you would be able to develop a fix quick= er than other folks since you are already familiar with the issues involved. (Also, you've fixed other related issues recently.) =2D-=20 John Baldwin