From nobody Mon Sep 18 00:01:51 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RplMk32Qhz4t4lZ; Mon, 18 Sep 2023 00:01:54 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RplMk1p4xz3WbT; Mon, 18 Sep 2023 00:01:54 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694995314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yEyHKZr27EKl9VsQxKPH7g4iwbflTFPQ3bCo+ZW7gpY=; b=tuM0aV0FV2LRC2ubQORfqoj4t2DivYUFH/9CiE2ajqsb4juYgUf5YXuw6Zyru2oDlghj/9 k4e9Coouwjsu/rkDYzNrAyDRca5kCLU7VlciNtf41QDDt+jkrP+b5bErv/nahZXhDHv4PF Gsx3Fqc7VqvZpIzzAMAt1uYGJgIkAQ5jkSRbHLpzQPOOcaHfLY72/8Z3fkC791tJZZtaZO TuS70Ej0ErtDqi/SRX63xfUseKsKDtf7Z2AsaLtp35hY5YxzArQcV8ld3tUdLiMW2VLFpX Md37xrB+FxgK3RCRdhVNfIpiwCT8AN8yU3r6uTeDuqlNZbZU6yAfJHJXsH54Hg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694995314; a=rsa-sha256; cv=none; b=i8YzC9GhVWPNifovRJQjOxanO2e3S6EZlDBOpiH8P5N5I+Kc0sqhosTqQrkMlyjfOEr0aS QkJijb9XfRJYdBVKpiGiN4P5RG+TXWA21wv+03BwnJpEFx49PfwxfNTZlnuGcuGDmACO3j FAYRfeUH8PV1TLK/5lCGq8vIrtWbxnrhDGBaxe9lTfhqJZXi/dt7n0ZAPWm8c3uD7FslI1 BRpFp7kXczACpIt2THIo5hddonU+FDog7AgJ/qV0Sg4NJifefs7XfpeMnNOdmphNJEuwku T5DHRYKMQDQGoh1P2ch+LkoBXZtEsGm/nwvJt+pNJ4bMRkL05Dw8UzV5Ey8wUA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694995314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yEyHKZr27EKl9VsQxKPH7g4iwbflTFPQ3bCo+ZW7gpY=; b=eibkPK2v3Ajv1T8VAVyu6yvb5RNmB2GkQeU0NFfqvHTPEVZmjsUhU+A++B+yGefhc8l9bk n+LXP0S+s0HGuDglXpw3nmIgnU1HgyuuGRE88G7fYUQb97j1dJ/0AVLsVQltjAo3e5iMK2 kRIq7pJQadZYW5nQszZaV2ggvP11sSoC+mXaUjFTO2YD00KFppPtu/5kHmY2UHjxYN5+hu aIv36Lzzc3F4BnQO06ncvYRESPXv9sIVHnMm/zb5tARD47DQJJ9E5BlIbOtZEuJpYLIHPA dNr2P6KWUWNjQgntfVpiX0amxctx4Llh+RoYXOWlo1hCU6p2w8BSW96xrx7yRg== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RplMk0HH8z11ZF; Mon, 18 Sep 2023 00:01:54 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 5A177EA29; Mon, 18 Sep 2023 02:01:52 +0200 (CEST) From: Kristof Provost To: Ed Maste Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1a18383a52bc - main - libcrypto: link engines and the legacy provider to libcrypto Date: Mon, 18 Sep 2023 01:01:51 +0100 X-Mailer: MailMate (1.14r5937) Message-ID: <44E31276-1371-47E7-AB8E-9EC45728CE15@FreeBSD.org> In-Reply-To: <202309161555.38GFtUXj064786@gitrepo.freebsd.org> References: <202309161555.38GFtUXj064786@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 16 Sep 2023, at 16:55, Ed Maste wrote: > The branch main has been updated by emaste: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D1a18383a52bc373e316d224c= ef1298debf6f7e25 > > commit 1a18383a52bc373e316d224cef1298debf6f7e25 > Author: Pierre Pronchery > AuthorDate: 2023-09-15 15:14:16 +0000 > Commit: Ed Maste > CommitDate: 2023-09-16 15:55:12 +0000 > > libcrypto: link engines and the legacy provider to libcrypto > > OpenSSL's legacy provider module and engines need to link to > libcrypto.so, as it provides some of the actual implementations of > legacy routines. > > This is a little tricky due to build order issues. Introduce a sma= ll > hack (LIBCRYPTO_WITHOUT_SUBDIRS) that builds libcrypto.so in its us= ual > early phase without any OpenSSL provider modules or engines. This = is > intended to restore the test suite; a future change should remove t= he > hack and replace it with a better approach. > > PR: 254853, 273528 > Discussed with: Folks at EuroBSDCon in Coimbra > Sponsored by: The FreeBSD Foundation MFC after: 3 days? We=E2=80=99ll want this in 14.0. Best regards, Kristof