From owner-svn-src-stable@freebsd.org Tue Jan 17 09:56:10 2017 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D6DD5CB0F8B; Tue, 17 Jan 2017 09:56:10 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9AC6A1558; Tue, 17 Jan 2017 09:56:10 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v0H9u2ku071088; Tue, 17 Jan 2017 01:56:03 -0800 (PST) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd-rwg@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v0H9tvtj071087; Tue, 17 Jan 2017 01:55:57 -0800 (PST) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201701170955.v0H9tvtj071087@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r312322 - stable/11/tests/sys/file In-Reply-To: <201701170156.v0H1uiRs075082@repo.freebsd.org> To: Ngie Cooper Date: Tue, 17 Jan 2017 01:55:57 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 09:56:11 -0000 > Author: ngie > Date: Tue Jan 17 01:56:44 2017 > New Revision: 312322 > URL: https://svnweb.freebsd.org/changeset/base/312322 > > Log: > MFC r312111: > > Remove unused vars to fix -Wunused issues The actual mistake here is that these are unused, a main() should do at least a check on argc to see if the correct number of args has been passed, and print a usage() if it has not: freebsd-rwg {105}% pwd /A/freebsd-rwg freebsd-rwg {106}% pwd foo usage: pwd [-LP] > Modified: > stable/11/tests/sys/file/ftruncate_test.c > Directory Properties: > stable/11/ (props changed) > > Modified: stable/11/tests/sys/file/ftruncate_test.c > ============================================================================== > --- stable/11/tests/sys/file/ftruncate_test.c Tue Jan 17 01:55:14 2017 (r312321) > +++ stable/11/tests/sys/file/ftruncate_test.c Tue Jan 17 01:56:44 2017 (r312322) > @@ -57,7 +57,7 @@ static off_t lengths[] = {0, 1, 2, 3, 4, > static int lengths_count = sizeof(lengths) / sizeof(off_t); > > int > -main(int argc, char *argv[]) > +main(void) > { > int error, fd, fds[2], i, read_only_fd; > char path[PATH_MAX]; > _______________________________________________ > svn-src-stable-11@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-stable-11 > To unsubscribe, send any mail to "svn-src-stable-11-unsubscribe@freebsd.org" > -- Rod Grimes rgrimes@freebsd.org