From owner-svn-ports-head@freebsd.org Wed Jan 29 10:17:38 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 29FBC1D2668; Wed, 29 Jan 2020 10:17:38 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486zv60Jhwz4Pk4; Wed, 29 Jan 2020 10:17:38 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id DC28B522F; Wed, 29 Jan 2020 10:17:37 +0000 (UTC) From: Jan Beich To: Christoph Moench-Tegeder Cc: Greg V , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r516629 - head/net/liferea References: <201911041019.xA4AJYqc047310@repo.freebsd.org> <20191104103901.GA2476@elch.exwg.net> <20200128001023.GA62291@elch.exwg.net> Date: Wed, 29 Jan 2020 11:17:36 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2020 10:17:38 -0000 Christoph Moench-Tegeder writes: [ ... http://docs.freebsd.org/cgi/mid.cgi?20200128001023.GA62291 ... ] > So, opinions against doing just that? I've no idea if it would even make > sense to try to support WPE on FreeBSD or if it's just something we > inherited "because it's there" as someone upstream had declared > underpowered mobile devices to be the future. WPE dependency was added in https://bugs.webkit.org/show_bug.cgi?id=197944 WPE renderer is unstable for me under Sway (Wayland compositor) e.g., Midori hangs shortly after startup. Greg, can you confirm? I've used the following diff to test WPE disabled. diff --git a/net/liferea/Makefile b/net/liferea/Makefile index b6437109e11a..7a775e48d2eb 100644 --- a/net/liferea/Makefile +++ b/net/liferea/Makefile @@ -11,8 +11,6 @@ COMMENT= Simple RSS/RDF feed reader LICENSE= GPLv2 -BROKEN= fails to build - BUILD_DEPENDS= gsettings-desktop-schemas>=0:devel/gsettings-desktop-schemas LIB_DEPENDS= libsoup-2.4.so:devel/libsoup \ libwebkit2gtk-4.0.so:www/webkit2-gtk3 \ diff --git a/www/webkit2-gtk3/Makefile b/www/webkit2-gtk3/Makefile index 4f92b2b1aefe..70a9a55dcd55 100644 --- a/www/webkit2-gtk3/Makefile +++ b/www/webkit2-gtk3/Makefile @@ -3,6 +3,7 @@ PORTNAME= webkit PORTVERSION= 2.26.3 +PORTREVISION= 1 CATEGORIES= www MASTER_SITES= https://webkitgtk.org/releases/ PKGNAMESUFFIX= 2-gtk3 @@ -65,7 +66,7 @@ INSTALL_TARGET= install BROWSER_PLUGINS_DIR?= ${LOCALBASE}/lib/browser_plugins/symlinks/webkit-gtk3 -OPTIONS_DEFINE= DEBUG GEOIP WAYLAND +OPTIONS_DEFINE= DEBUG GEOIP WAYLAND WPE OPTIONS_DEFAULT= GEOIP WAYLAND OPTIONS_SUB= yes @@ -91,9 +92,13 @@ GEOIP_BUILD_DEPENDS= geoclue>=2.4.3:net/geoclue GEOIP_RUN_DEPENDS= geoclue>=2.4.3:net/geoclue WAYLAND_CMAKE_BOOL= ENABLE_WAYLAND_TARGET -WAYLAND_LIB_DEPENDS= libwayland-egl.so:graphics/wayland \ - libwpe-1.0.so:www/libwpe \ +WAYLAND_LIB_DEPENDS= libwayland-egl.so:graphics/wayland + +WPE_DESC= Use WPEBackend-fdo instead of nested compositor +WPE_CMAKE_BOOL= USE_WPE_RENDERER +WPE_LIB_DEPENDS= libwpe-1.0.so:www/libwpe \ libWPEBackend-fdo-1.0.so:www/wpebackend-fdo +WPE_IMPLIES= WAYLAND post-patch: @${REINPLACE_CMD} -e 's|/usr/lib/browser/plugins|${BROWSER_PLUGINS_DIR}|' \