From owner-freebsd-multimedia  Sat Mar 29 13:43:39 1997
Return-Path: <owner-multimedia>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id NAA15038
          for multimedia-outgoing; Sat, 29 Mar 1997 13:43:39 -0800 (PST)
Received: from rah.star-gate.com (rah.star-gate.com [204.188.121.18])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id NAA15033
          for <multimedia@freebsd.org>; Sat, 29 Mar 1997 13:43:36 -0800 (PST)
Received: from rah.star-gate.com (localhost.star-gate.com [127.0.0.1]) by rah.star-gate.com (8.8.5/8.7.3) with ESMTP id NAA11959; Sat, 29 Mar 1997 13:43:33 -0800 (PST)
Message-Id: <199703292143.NAA11959@rah.star-gate.com>
X-Mailer: exmh version 1.6.9 8/22/96
To: Richard Tobin <richard@cogsci.ed.ac.uk>
cc: Steve Passe <smp@csn.net>, multimedia@freebsd.org
Subject: Re: newest bt848 driver 
In-reply-to: Your message of "Sat, 29 Mar 1997 21:17:24 GMT."
             <28054.199703292117@pitcairn.cogsci.ed.ac.uk> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sat, 29 Mar 1997 13:43:33 -0800
From: Amancio Hasty <hasty@rah.star-gate.com>
Sender: owner-multimedia@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


Hi,

Yes, it is my mistake. Please change it to:
	bktr->dma_prog = get_bktr_mem(unit, 8*4096);
	bktr->odd_dma_prog = get_bktr_mem(unit, 8*4096);


If you have enough time please use a define symbol similar 
to BROOKTREE_ALLOC for allocating the dma program segments.

The reason why it is working is because of round_page in vm_page.c 
rounds up to the nearest page so get_bktr_mem is getting 1 Page (4096 bytes).

For sure it needs to be fixed!


	Tnks!
	Amancio


>From The Desk Of Richard Tobin :
> > get_bktr_mem allocates memory in terms of pages (4096 bytes)
> 
> No it doesn't!
> 
> See what it does for the main memory:
> 
> #define BROOKTREE_ALLOC		(BROOKTREE_ALLOC_PAGES * PAGE_SIZE)
> ...                                                    ^^^^^^^^^^^
>     if ( BROOKTREE_ALLOC )
>         buf = get_bktr_mem(unit, BROOKTREE_ALLOC);
> 
> -- Richard