From owner-cvs-src@FreeBSD.ORG Wed Apr 30 17:40:24 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6AD0E106566B; Wed, 30 Apr 2008 17:40:24 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id 437E78FC0A; Wed, 30 Apr 2008 17:40:24 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.2/8.14.2) with ESMTP id m3UHeOSi022539; Wed, 30 Apr 2008 10:40:24 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.2/8.14.1/Submit) id m3UHeNvr022538; Wed, 30 Apr 2008 10:40:23 -0700 (PDT) (envelope-from obrien) Date: Wed, 30 Apr 2008 10:40:23 -0700 From: "David O'Brien" To: Sam Leffler Message-ID: <20080430174023.GA22190@dragon.NUXI.org> References: <200804292135.m3TLZONF045026@repoman.freebsd.org> <20080430165352.GA89079@dragon.NUXI.org> <4818A559.1010903@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4818A559.1010903@freebsd.org> X-Operating-System: FreeBSD 8.0-CURRENT User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: CVSROOT exclude X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Apr 2008 17:40:24 -0000 On Wed, Apr 30, 2008 at 09:59:05AM -0700, Sam Leffler wrote: > David O'Brien wrote: >> On Tue, Apr 29, 2008 at 09:35:24PM +0000, Sam Leffler wrote: >>> . exclude Log: >>> add iwn firmware >> >> Hi Sam, >> I notice we keep excluding $FreeBSD$ from uuencoded firmware files. >> At least looking at sys/contrib/dev/iwn/iwlwifi-4965-4.44.17.fw.uu, >> which has a Copyright notice at the top, I think the use of this file >> would tolerate a $FreeBSD$ on the first line. >> >> Would you mind if I fixed this? >> > I copied previous practice in excluding the entire directory. I think "the previous practice" mostly comes from the wireless firmware where the folks committing it may not have realized that "$FreeBSD$" will be nicely ignored by uudecode. > The issue > isn't whether it's possible to insert a keyword but rather whether it's a > good idea to alter files (like the LICENSE files) that come directly from > "the vendor" under limited terms. # $FreeBSD: src/sys/contrib/dev/ral/rt2860.fw.uu,v 1.1 2008/04/20 20:35:35 sam Exp $ (and the other *.uu's there) are examples where we've done it. And I think its fine. Note, if these come straight from a vendor, why aren't they being vendor imported? -- -- David (obrien@FreeBSD.org)