From owner-dev-commits-src-all@freebsd.org Sun Sep 26 01:49:23 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8943766C47D; Sun, 26 Sep 2021 01:49:23 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HH7wz3DRTz4Y9v; Sun, 26 Sep 2021 01:49:23 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (unknown [IPv6:2601:648:8681:1cb0:e948:53aa:fce5:d12d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id C92CC20D2B; Sun, 26 Sep 2021 01:49:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: git: 9d324b5ffc8a - main - mount: Don't pass a NULL format string to xo_err(). To: "Piotr P. Stefaniak" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202109251852.18PIqN8T032119@gitrepo.freebsd.org> From: John Baldwin Message-ID: Date: Sat, 25 Sep 2021 18:49:21 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Sep 2021 01:49:23 -0000 On 9/25/21 11:57 AM, Piotr P. Stefaniak wrote: > On 2021-09-25 18:52:23, John Baldwin wrote: >> The branch main has been updated by jhb: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=9d324b5ffc8a783ceff2a78dea19602a1d8f045a >> >> commit 9d324b5ffc8a783ceff2a78dea19602a1d8f045a >> Author: John Baldwin >> AuthorDate: 2021-09-25 18:51:01 +0000 >> Commit: John Baldwin >> CommitDate: 2021-09-25 18:52:10 +0000 >> >> mount: Don't pass a NULL format string to xo_err(). >> >> This fixes a -Wformat error from GCC 9. >> >> Fixes: e725ee7eb672 mount: add libxo(3) support > > Sorry, I missed that. Thanks for fixing it! No worries. I'm not sure why clang's -Wformat doesn't catch this. -- John Baldwin