From owner-svn-src-head@FreeBSD.ORG Tue Oct 8 23:12:51 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 351DA420; Tue, 8 Oct 2013 23:12:51 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from mail0.glenbarber.us (mail0.glenbarber.us [IPv6:2607:fc50:1:2300:1001:1001:1001:face]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E200D29C9; Tue, 8 Oct 2013 23:12:50 +0000 (UTC) Received: from glenbarber.us (c-71-224-221-174.hsd1.nj.comcast.net [71.224.221.174]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: gjb) by mail0.glenbarber.us (Postfix) with ESMTPSA id 67688885D; Tue, 8 Oct 2013 23:12:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.8.3 mail0.glenbarber.us 67688885D Authentication-Results: mail0.glenbarber.us; dkim=none reason="no signature"; dkim-adsp=none Date: Tue, 8 Oct 2013 19:12:47 -0400 From: Glen Barber To: Jim Harris Subject: Re: svn commit: r256151 - in head/sys/dev: nvd nvme Message-ID: <20131008231247.GA5745@glenbarber.us> References: <201310081544.r98Fi4R8096543@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl" Content-Disposition: inline In-Reply-To: <201310081544.r98Fi4R8096543@svn.freebsd.org> X-Operating-System: FreeBSD 10.0-ALPHA4 amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Oct 2013 23:12:51 -0000 --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 08, 2013 at 03:44:04PM +0000, Jim Harris wrote: > Author: jimharris > Date: Tue Oct 8 15:44:04 2013 > New Revision: 256151 > URL: http://svnweb.freebsd.org/changeset/base/256151 >=20 > Log: > Add driver-assisted striping for upcoming Intel NVMe controllers that c= an > benefit from it. > =20 > Modified: head/sys/dev/nvme/nvme_ns.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/nvme/nvme_ns.c Tue Oct 8 14:10:32 2013 (r256150) > +++ head/sys/dev/nvme/nvme_ns.c Tue Oct 8 15:44:04 2013 (r256151) > @@ -34,13 +34,31 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > +#include > #include > #include > =20 > #include > =20 > +#include > + > #include "nvme_private.h" > =20 I think an include is missing. This breaks the LINT build. cc -c -O2 -pipe -fno-strict-aliasing -std=3Dc99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -nostdinc -I. -I/src/sys -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -DGPROF -DGPROF4 -DGUPROF -fno-builtin -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -mno-aes -mno-avx -mcmodel=3Dkernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -Werror -pg /src/sys/dev/nvme/nvme_ns.c In file included from /src/sys/dev/nvme/nvme_ns.c:43: /src/sys/geom/geom.h:356:3: error: implicit declaration of function 'KASSERT' is invalid in C99 [-Werror,-Wimplicit-function-declaration] KASSERT(g_valid_obj(ptr) =3D=3D 0, ^ /src/sys/geom/geom.h:357:8: error: expression result unused [-Werror,-Wunused-value] ("g_free(%p) of live object, type %d", ptr, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /src/sys/geom/geom.h:357:46: error: expression result unused [-Werror,-Wunused-value] ("g_free(%p) of live object, type %d", ptr, ^~~ 3 errors generated. *** Error code 1 http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-amd64-amd64.full Glen --BXVAT5kNtrzKuDFl Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBCAAGBQJSVJFvAAoJELls3eqvi17QEOsP/2pJ4EYdBapH9eBoKHf89MBC 5mehp2woHgD8dCcuFVKpMne53qylTtY1NGlQBoDB9nu46DKJSyN2k09G09aEXuIY +gHMuLvDG/f6+cZNRz5Gd5muvQkkrJPiTYl8i378JZ3aseM014p0bSpgWQOxDkc/ KVN9T0Wp2HnELwvbHKBR5haMokyBh+SO4+ReJsjJ0CKv6I7jlopAoEyu1FnSXp8g 29Hgnq9VDj4TTO3eK9Lgju/9mJtu7J/r1Fhpgvp9lpF7a+NCJN4QaI5H/0cleyqx 2XWpPiYlxKNlnNsaSBbiUw2rhmxPAZMLbi4aoh0MP6WqD6s7x/1K/Hdg+R4XCs/C KBK3d11gcPH0P9YQb8P8Ph9/kt0xeLy1bEfRTkiOOPL5TQEqIhbtfqHAZCI6wFwf nIaA60Ooafu8tIZ27KgYXnc8Re2jrHpD1miipbzIBoUh21+N6qHKn3aM+alvCqJH dlaq/Qbb8fPyRZczsr9FQSLbYfAxKSkMOgXBMK1kv32K2+Bwx+tpab94vLJ175a0 6Wlbj/X6ciH1KXvftBbJrKyqJ1cKB+EA5Kbd6IiKceVg58HFGENO3O9i69BuIB+K SXT2oE5nv7YMQJUziG7YkPWzn6WdOG6K1Rnnm5jMyGd8ecm1ZmcckvBaJ10Mgx/8 iStlITzbt8kR600ARGAj =lpGw -----END PGP SIGNATURE----- --BXVAT5kNtrzKuDFl--