From nobody Sat Sep 23 02:26:03 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RstKl4DKZz4tr5J; Sat, 23 Sep 2023 02:26:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RstKl3kwjz3PND; Sat, 23 Sep 2023 02:26:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695435963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UO3h6SDvKcstcTTpUxYcezZd/x5rIoDaucLfBMYz4ig=; b=rg+nDQ1+2pjNxgFfll+/8rlixHEcq6OrLuvJ3njYXQR3kYW+gxi3wZ8EEeMTcijTcS0w1y 3N2PmcPklMyA2SHWo7gpaGBfOQpCdIw/Wq7EA85+PAR3ehY9yb8wg/jblEM+TAangIWlMA Qr5p7oVfkZRLoU/vWuUll2i/inuC2qrH9pDAy8znmob1xhg/hRgrG6UuREWqq+vEw8o3ZD u371LBHtwwJISTnfWMZvsKrqUQfau3F9Scfazh+ORxWz8p57mTc7KB7F/HuGDLyzxgUzXv exObHl3dYkcYK1sDVmzdrcCvizE4EVDFjCz2rZJeMe1XjG94YtSy2GONNzsM1w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695435963; a=rsa-sha256; cv=none; b=u6zyrXd9TbX4NzU0PLj3hfftcpp9/ncEEvjv+twzMD6O+rUNCsv7KATjGnSg9oZUN0s+Yf d60ca55//6GJZqUTaRAZRkzrS1jo445nLCqj3da3tNnaEgfWiWDEIh0rEaxp8JOhCB76XI IV7fzZdSNED8VSHdK/TbnRpbuSX3k8hbwS/jW14/xMiewRi6thkDepQwVK1dKAPYyh5UHX mak0+fm2W7XoZdDXrvgHV5R4q8TY18xsb0010ddXyZAZ/qa/4C6EvueLvb87YCGerHgh1K wfFinhPzYcwSwW80JlCBYnhduCpWHET2sGiRZI1akK6a3E0BiwQAHmV7+sHTsA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695435963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UO3h6SDvKcstcTTpUxYcezZd/x5rIoDaucLfBMYz4ig=; b=VlmGCGdAImIhrlF6/fT9aCWXIC2Nypp/2cpGutMUvQY71IO8TKkNnmcscyuEbPLDkLG/Pz XpmuqSGhPU89dOSMTGBac1oQKx+foOVR0DMBQRTbLjb5KgPnHUl86glN2uGS1yj/l1NOqv WklKDnAJ4kuvs1/CEzIqCBpU9omzhO+TrvGew7Wojs91IUJzdl1RlP99q47kn5R7p7zSbM tY+dFPgW2N2laTSrimT3NpgDqhMmCxehFWDdTRok4FymTl6aVPP+2xONH81URAft4HQevu 4RqBvxQUTDgskzm1pYoW3oaO3WFoyhz4mCVLaLopHwDJhPJp3CXBin7mWFvENg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RstKl2gjfzmD9; Sat, 23 Sep 2023 02:26:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38N2Q3dB007757; Sat, 23 Sep 2023 02:26:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38N2Q3S0007754; Sat, 23 Sep 2023 02:26:03 GMT (envelope-from git) Date: Sat, 23 Sep 2023 02:26:03 GMT Message-Id: <202309230226.38N2Q3S0007754@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mike Karels Subject: git: 4fdded885b8d - releng/14.0 - clk_fixed: reduce and clarify messages due to missing clk-frequency List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: karels X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: 4fdded885b8d587a5e0a7377361c0eaaa96af30e Auto-Submitted: auto-generated The branch releng/14.0 has been updated by karels: URL: https://cgit.FreeBSD.org/src/commit/?id=4fdded885b8d587a5e0a7377361c0eaaa96af30e commit 4fdded885b8d587a5e0a7377361c0eaaa96af30e Author: Mike Karels AuthorDate: 2023-08-25 20:11:46 +0000 Commit: Mike Karels CommitDate: 2023-09-23 02:24:22 +0000 clk_fixed: reduce and clarify messages due to missing clk-frequency The current dts for Raspberry 3B+ and 4B have 2 disabled fixed-clock nodes which have no clock-frequency value. Such nodes are non-standard. This results in about 150 messages during autoconfiguration: clk_fixed2: disabled on ofwbus0 clk_fixed2: Cannot FDT parameters. device_attach: clk_fixed2 attach returned 6 Defensively check for clock-frequency in the probe routine, and if none, return an error with a more direct error message (1 line per occurrence, 50 lines total): clk_fixed2: clock-fixed has no clock-frequency Based on a patch by manu. Approved by: re(gjb) Reviewed by: manu Differential Revision: https://reviews.freebsd.org/D41594 (cherry picked from commit b4ef09b9eb117d622bb274448e5cffcae0ba3488) (cherry picked from commit 2476a76031908016dd2513862d46ad8dd2bab462) --- sys/dev/extres/clk/clk_fixed.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/dev/extres/clk/clk_fixed.c b/sys/dev/extres/clk/clk_fixed.c index f4f1d462233a..e5ca6b31d000 100644 --- a/sys/dev/extres/clk/clk_fixed.c +++ b/sys/dev/extres/clk/clk_fixed.c @@ -157,6 +157,11 @@ clk_fixed_probe(device_t dev) clk_type = ofw_bus_search_compatible(dev, compat_data)->ocd_data; switch (clk_type) { case CLK_TYPE_FIXED: + if (OF_hasprop(ofw_bus_get_node(dev), "clock-frequency") == 0) { + device_printf(dev, + "clock-fixed has no clock-frequency\n"); + return (ENXIO); + } device_set_desc(dev, "Fixed clock"); return (BUS_PROBE_DEFAULT); case CLK_TYPE_FIXED_FACTOR: