From owner-freebsd-scsi@FreeBSD.ORG Tue Dec 5 03:11:50 2006 Return-Path: X-Original-To: freebsd-scsi@FreeBSD.org Delivered-To: freebsd-scsi@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7DEA216A417; Tue, 5 Dec 2006 03:11:50 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1-3.pacific.net.au [61.8.2.210]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F36843CA2; Tue, 5 Dec 2006 03:11:13 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id 8F8CA5A0E9A; Tue, 5 Dec 2006 14:11:43 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id AC28727415; Tue, 5 Dec 2006 14:11:42 +1100 (EST) Date: Tue, 5 Dec 2006 14:11:42 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: mjacob@FreeBSD.org In-Reply-To: <20061204150922.F18492@ns1.feral.com> Message-ID: <20061205140644.Q28464@delplex.bde.org> References: <20061119161631.L44297@ns1.feral.com> <3bbf2fe10611191631h6883b862uf8088533913a7bc6@mail.gmail.com> <20061120221153.GA5155@lor.one-eyed-alien.net> <3bbf2fe10611201418m15d50703m37d9d5620e5c832d@mail.gmail.com> <20061204150922.F18492@ns1.feral.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Attilio Rao , freebsd-scsi@FreeBSD.org Subject: Re: a code reduction function addition to cam_xpt X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2006 03:11:50 -0000 On Mon, 4 Dec 2006 mjacob@FreeBSD.org wrote: > Was there ever a consensus about this to the point of: > > a) Yes, this is a nice thing to have > b) Should it be a define or a function? > > I obviously think yes for #a. I lean toward a function. Comments? I wouldn't have thought of using a macro except for an entry in IOCCC. Bruce