Date: Sat, 20 May 2017 06:06:35 -0300 From: Joseph Mingrone <jrm@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: Dan Langille <dvl@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r441282 - in head: . security security/acme.sh Message-ID: <86d1b3lwx0.fsf@phe.ftfl.ca> In-Reply-To: <989C2BB0-AC4E-4C76-AB15-9F616A6EF392@adamw.org> (Adam Weinberger's message of "Fri, 19 May 2017 21:43:46 -0600") References: <201705200227.v4K2RjjG055940@repo.freebsd.org> <989C2BB0-AC4E-4C76-AB15-9F616A6EF392@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain Adam Weinberger <adamw@adamw.org> writes: >> On 19 May, 2017, at 20:27, Dan Langille <dvl@FreeBSD.org> wrote: >> Author: dvl >> Date: Sat May 20 02:27:45 2017 >> New Revision: 441282 >> URL: https://svnweb.freebsd.org/changeset/ports/441282 >> Log: >> A pure Unix shell script implementing ACME client protocol >> Differential Revision: https://reviews.freebsd.org/D10308 >> Added: >> head/security/acme.sh/ >> head/security/acme.sh/Makefile (contents, props changed) >> head/security/acme.sh/distinfo (contents, props changed) >> head/security/acme.sh/pkg-descr (contents, props changed) >> Modified: >> head/GIDs >> head/UIDs >> head/security/Makefile >> +RUN_DEPENDS= curl:ftp/curl >> + >> +OPTIONS_DEFINE= CURL DOCS WGET >> +OPTIONS_DEFAULT= CURL >> +CURL_DESC= Add ftp/curl as a run-time dependency >> +WGET_DESC= Add ftp/wget as a run-time dependency >> + >> +CURL_RUN_DEPENDS= curl:ftp/curl >> +WGET_RUN_DEPENDS= wget:ftp/wget > Hi Dan, > You have curl as a mandatory and optional dependency, which effectively makes curl mandatory. I think you want to use OPTIONS_SINGLE or OPTIONS_MULTI here, to make it an actual choice between the two of them. > Also the descriptions are a bit strange. I mean, it does add them as a dependency, but I think an end-user would be more concerned with what curl or wget does for acme.sh, no? > # Adam Hi Adam, Dan, The link below is a patch with proposed changes. http://ftfl.ca/misc/acme.sh-2.6.9.diff Changelog: - Add OPTION_SINGLE for choosing one of cURL or Wget for HTTP(s) queries - Update CURL/WGET descriptions [1] - Silence porlint warnings [1] They do not say "Use cURL/Wget...", because acme.sh will, by default, use cURL if both cURL and Wget are installed Joseph --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEVbCTpybDiFVxIrrVNqQMg7DW754FAlkgBxxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUACgkQNqQMg7DW 7564Cw/9EZeDpiJau9ruEgkGWbwndYNrAVsX71YeF20wCqIr+A631wcHGH0MABQF olGy2ToQVf4UekFv8s1YrE3WcNU+IjPwGu0XWlfQLwIzvVkS+SptWUrV62yyLVTA iibQ2aOwi6H4YcoNGoP/CfOpsi6q6fswU8GxTb2c8bD9LcC+pZG3FEz9bV94J0jM kYF3rssITckxvLIcTugvNrJjJHnzSIGeVGjERnP1KQlPA7APmm0pVOQBW324mxg/ 7XSlU2V6rEu2faLaVUckJ23N9+RsfmrSkGBe3BhQRv+AvWm1VidO1B3XFGPa3pqk jUqyDyTD3mWik+yMzKMPiURT5qC27jCu4caQezE/YS3FVovf9+549XUSoOjsKJJb ED9jBsGo4ClCxt6EapJaEDjR6E72zyfP4zSJ7W/cNlUuhW4O9dYcdWfXUhxbdGau XOsAWv+5/FGhXBkR8qu6dX4vNkeaGGXYbR4OvdX0DmsFbx0WyBMZcF35Cs/ptfYn x+HAnwzFNKRZ4iZVn1AXbAYnRYOYjff8B6iRpGMYb7M7JWj6iwLs5l4j/1YXtiqv KenhsRXzbY7/AGZha8qE1wGmFL/mSMN3RqwwdM6BuO9LK55fXLWx+iBm0fP3s4MK d6cVLOu9/+ilLe67a5X/R2ZRh9uaat6LtvQ01pFD2YYcZZkH1Y4= =Djsy -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86d1b3lwx0.fsf>