From owner-freebsd-hackers@FreeBSD.ORG Sat Nov 6 19:47:12 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09914106566C; Sat, 6 Nov 2010 19:47:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 7C9F68FC13; Sat, 6 Nov 2010 19:47:10 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id oA6Jl6e2024826 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 6 Nov 2010 21:47:06 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id oA6Jl6PN074187; Sat, 6 Nov 2010 21:47:06 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id oA6Jl2jJ074184; Sat, 6 Nov 2010 21:47:02 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 6 Nov 2010 21:47:02 +0200 From: Kostik Belousov To: Alexander Kabaev Message-ID: <20101106194702.GN2392@deviant.kiev.zoral.com.ua> References: <20100805191446.GJ14016@felucia.tataz.chchile.org> <20100919081406.GH6864@felucia.tataz.chchile.org> <20100919184146.GE2389@deviant.kiev.zoral.com.ua> <20100920162925.GL6864@felucia.tataz.chchile.org> <20100920192708.GK2389@deviant.kiev.zoral.com.ua> <20100927094651.GB57265@felucia.tataz.chchile.org> <20100927154457.GJ43070@deviant.kiev.zoral.com.ua> <20101005181804.GJ7536@felucia.tataz.chchile.org> <20101105213905.GT30284@felucia.tataz.chchile.org> <20101105190023.29e5d39d@kan.dnsalias.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="f054HvE3bsu5oaav" Content-Disposition: inline In-Reply-To: <20101105190023.29e5d39d@kan.dnsalias.net> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: kan@freebsd.org, freebsd-hackers@freebsd.org, Jeremie Le Hen Subject: Re: [PATCH] Add -lssp_nonshared to GCC's LIB_SPEC unconditionally X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2010 19:47:12 -0000 --f054HvE3bsu5oaav Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 05, 2010 at 07:00:23PM -0400, Alexander Kabaev wrote: > On Fri, 5 Nov 2010 22:39:06 +0100 > Jeremie Le Hen wrote: >=20 > > Hi Kib, > >=20 > > On Tue, Oct 05, 2010 at 08:18:04PM +0200, Jeremie Le Hen wrote: > > >=20 > > > On Mon, Sep 27, 2010 at 06:44:57PM +0300, Kostik Belousov wrote: > > > > Hardcoding /usr/lib as the path to the library in the script looks > > > > problematic. For the buidlworld, you are linking resulting > > > > binaries with the host library, instead of the > > > > buildworld-produced one. For lib32, it makes non-working > > > > combination of 32/64 bit. > > >=20 > > > Sorry for the late reply, but I had to collect various evidences > > > for my sayings and my development machine is reaaaaaaaaaaally slow. > > >=20 > > > In fact it seems the toolchain built for buildworld contains a ld(1) > > > binary which invariably bases lookups for libraries in ${WORLDTMP}, > > > even in case of an absolute path. I have two evidences of this: > > > - Putting /usr/obj/usr/src/tmp/usr/lib/libssp_nonshared.a in > > > /usr/obj/usr/src/tmp/usr/lib/libc.ld leads toolchain's ld(1) to > > > use /usr/obj/usr/src/tmp/usr/obj/usr/src/tmp/usr/lib/libssp_nonshared= .a; > > > - I also verified this with a hand-wrought opensnoop-like DTrace > > > script. > >=20 > > I dare to remind you about my patch. Do you have any other concerns? > >=20 > > Thanks. > > Regards, > > --=20 > > Jeremie Le Hen > >=20 > > Humans are born free and equal. But some are more equal than others. > > Coluche >=20 > Hmm, I thought I did approve this patch already a long time agi, but > since you asked: >=20 > +.if defined(SHLIB_LDSCRIPT) && exists(${.CURDIR}/${SHLIB_LDSCRIPT}) >=20 > this should be: >=20 > +.if defined(SHLIB_LDSCRIPT) >=20 > ditto for all other similar places. Otherwise I do not think we should > hold the patch in queue ans should unleash it on unsuspecting public. Also, I think the "DEBUG" lines should be removed. You install the libxxx.ld and then symlink libxxx.so to libxxx.ld. Why ? Would it be enough to install just the libxxx.so ? Otherwise, I think you need the similar =2Eif ${SHLIBDIR} =3D=3D ${LIBDIR} magic, that is better to be avoided. --f054HvE3bsu5oaav Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAkzVsLYACgkQC3+MBN1Mb4jT/wCgxi4WlXr4+/xaU8A9E8Ke/Oul J4EAnRcsvYhEOI5bQrr9+ibq8hB8H3V8 =s1yG -----END PGP SIGNATURE----- --f054HvE3bsu5oaav--