From owner-freebsd-hackers@FreeBSD.ORG  Thu Aug  7 13:50:36 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DED6F1065671
	for <freebsd-hackers@freebsd.org>; Thu,  7 Aug 2008 13:50:36 +0000 (UTC)
	(envelope-from andenore@freebsd.org)
Received: from smtp.bluecom.no (smtp.bluecom.no [193.75.75.28])
	by mx1.freebsd.org (Postfix) with ESMTP id 95C958FC1F
	for <freebsd-hackers@freebsd.org>; Thu,  7 Aug 2008 13:50:36 +0000 (UTC)
	(envelope-from andenore@freebsd.org)
Received: from duckjen.nextgentel.no (cFC4401C3.dhcp.bluecom.no [195.1.68.252])
	by smtp.bluecom.no (Postfix) with ESMTP id 53C7710D70A5;
	Thu,  7 Aug 2008 15:48:16 +0200 (CEST)
Date: Thu, 07 Aug 2008 15:47:24 +0200
To: "Rui Paulo" <rpaulo@freebsd.org>
From: "Anders Nore" <andenore@freebsd.org>
Content-Type: text/plain; format=flowed; delsp=yes; charset=utf-8
MIME-Version: 1.0
References: <op.ufg273npp8qiwu@duckjen.nextgentel.no>
	<1234BBCE-6698-4EF9-8B48-4F291AD78547@freebsd.org>
Content-Transfer-Encoding: 7bit
Message-ID: <op.ufiq9awzp8qiwu@duckjen.nextgentel.no>
In-Reply-To: <1234BBCE-6698-4EF9-8B48-4F291AD78547@freebsd.org>
User-Agent: Opera Mail/9.50 (FreeBSD)
Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org>
Subject: Re: Suggestion for 'pkg_add -r'
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Aug 2008 13:50:37 -0000

>>
>> RELENG_7:
>> http://home.no.net/andenore/patches/pkg_install_2008-08-06_RELENG_7.diff
>>
>> CURRENT:
>> http://home.no.net/andenore/patches/pkg_install_2008-08-06_CURRENT.diff
>
> Some comments:
>    * I think you have reversed the patch. :-)
>    * Build errors:
> cc1: warnings being treated as errors
> file.c:433: warning: no previous prototype for 'power'
> file.c:452: warning: no previous prototype for 'human_readable'
> file.c:474: warning: no previous prototype for 'printHumanReadable'
> file.c: In function 'printHumanReadable':
> file.c:482: warning: comparison between signed and unsigned
>
> parallels# ./pkg_add -r joe
> Fetching 321.2 kB from  
> ftp://ftp.freebsd.org/pub/FreeBSD/ports/i386/packages-8-current/Latest/joe.tbz 
> ...
>                                        Downloading: 100%  321.2 kB at   
> 214.8 kB/s 
>                                                                              Done
> Fetching 2.4 MB from  
> ftp://ftp.freebsd.org/pub/FreeBSD/ports/i386/packages-8-current/All/gettext-0.17_1.tbz 
> ...
>                                                                              Done
> Fetching 2.2 MB from  
> ftp://ftp.freebsd.org/pub/FreeBSD/ports/i386/packages-8-current/All/aspell-0.60.6_2.tbz 
> ...
>                                        Downloading: 201%    4.5 MB at   
> 149.5 kB/s
>
> Something's wrong :-)
>

Heh, yes. It's my first patch(es), so it didn't go as well as I had hoped,  
I believe they are fixed now.
The numbers for percentage should also be corrected :-)

> Also, may I suggest that you make your output similar to fetch(1) ?

Yes, I will work on making it similar


Thanks,
Anders Nore