From owner-cvs-all Thu Dec 23 10:36:34 1999 Delivered-To: cvs-all@freebsd.org Received: from [132.197.97.45] (h132-197-97-45.gte.com [132.197.97.45]) by hub.freebsd.org (Postfix) with ESMTP id A5875156A0; Thu, 23 Dec 1999 10:36:30 -0800 (PST) (envelope-from ak03@gte.com) Received: (from ak03@localhost) by [132.197.97.45] (8.9.3/8.9.3) id NAA99720; Thu, 23 Dec 1999 13:35:54 -0500 (EST) (envelope-from ak03) Message-ID: X-Mailer: XFMail 1.3.1 [p0] on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <19991223121944.D70195@holly.calldei.com> Date: Thu, 23 Dec 1999 13:35:53 -0500 (EST) Organization: GTE Laboratories Inc. From: "Alexander N. Kabaev" To: Chris Costello Subject: Re: cvs commit: ports/misc/mc/patches patch-ai Cc: cvs-all@FreeBSD.ORG, Steve Price , "Rodney W. Grimes" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk I agree, that my patch does not take into account $PREFIX and thus it is not completely correct. I still believe most users will prefer this file to have hardcoded path which is correct in 99% cases instead of 100% incorrect one :). It is of course possible to use configure to generate Midnight Commander's 'VFS' scripts using correct paths to various utilities they use, but frankly I believe that the gain will not be worth the trouble. My patch was actually supposed to fix stupid syntactic error AWK code used to parse unzip output. Changing the path was a byproduct of that. On 23-Dec-99 Chris Costello wrote: > On Thu, Dec 23, 1999, Rodney W. Grimes wrote: >> > Log: >> > Find (un)zip in /usr/local instead of /usr/bin. >> >> Find (un)zip in $PATH? /usr/local is not always what folks use >> for $PREFIX :-( > > Both the original version and the patched version are > incorrect, as neither are correctly paying attention to $PREFIX. > > -- >|Chris Costello >|Health is merely the slowest possible rate at which one can die. > `---------------------------------------------------------------- > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe cvs-all" in the body of the message ---------------------------------- E-Mail: Alexander N. Kabaev Date: 23-Dec-99 Time: 13:20:30 ---------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message