From owner-dev-commits-src-main@freebsd.org Tue Jan 26 01:52:22 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A9404FB01E; Tue, 26 Jan 2021 01:52:22 +0000 (UTC) (envelope-from philip@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DPqVZ3vmqz4WFc; Tue, 26 Jan 2021 01:52:22 +0000 (UTC) (envelope-from philip@freebsd.org) Received: from weatherwax.trouble.is (weatherwax.trouble.is [46.235.227.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "weatherwax.trouble.is", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: philip/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 647154BA8; Tue, 26 Jan 2021 01:52:22 +0000 (UTC) (envelope-from philip@freebsd.org) Received: from rincewind.trouble.is (rincewind.trouble.is [IPv6:2a01:4f9:2a:1715::1:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "rincewind.trouble.is", Issuer "Let's Encrypt Authority X3" (verified OK)) by weatherwax.trouble.is (Postfix) with ESMTPS id 4DPqVY3MnVz1y8w; Tue, 26 Jan 2021 01:52:21 +0000 (UTC) Received: by rincewind.trouble.is (Postfix, from userid 1001) id 4DPqVX6lsGz6G7P; Tue, 26 Jan 2021 01:52:20 +0000 (UTC) Date: Tue, 26 Jan 2021 09:52:20 +0800 From: Philip Paeps To: Cy Schubert Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 83edbc3cb54f - main - ipfilter: Retire pre-standard C support. Message-ID: Mail-Followup-To: Cy Schubert , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202101252247.10PMlBd2027258@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <202101252247.10PMlBd2027258@gitrepo.freebsd.org> X-PGP-Fingerprint: 2CD1 92C2 6EE7 B7D1 F552 6619 31AE B9B5 FDBB CB0E X-Date: Today is Sweetmorn, the 26th day of Chaos in the YOLD 3187 X-Phase-of-Moon: The Moon is Waxing Gibbous (92% of Full) X-Clacks-Overhead: GNU Terry Pratchett Organization: Happily Disorganized X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2021 01:52:22 -0000 On 2021-01-25 22:47:11 (+0000), Cy Schubert wrote: > ipfilter: Retire pre-standard C support. > > All C compilers in 2021 support standard C and architectures that did > not were retired long ago. Simplify by removing now redundant > pre-standard C code. [...] > #ifndef __P >-# ifdef __STDC__ > # define __P(x) x >-# else >-# define __P(x) () >-# endif >-#endif You could simplify even further by getting rid of the __P() convention altogether. All our compilers support prototypes in 2021. :) Philip -- Philip Paeps Senior Reality Engineer Alternative Enterprises