From owner-dev-commits-src-all@freebsd.org Fri Mar 5 18:24:00 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1DEAA562A82; Fri, 5 Mar 2021 18:24:00 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DsbjD03cXz3GN2; Fri, 5 Mar 2021 18:24:00 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from localhost (p200300d5d740b9c950bd45a017f3c4cd.dip0.t-ipconnect.de [IPv6:2003:d5:d740:b9c9:50bd:45a0:17f3:c4cd]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 98E22A655; Fri, 5 Mar 2021 18:23:59 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Fri, 5 Mar 2021 19:23:56 +0100 From: Gordon Bergling To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 89b650872bba - main - ktls: Hide initialization message behind bootverbose Message-ID: References: <202103051815.125IFDNK001016@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202103051815.125IFDNK001016@gitrepo.freebsd.org> X-Url: X-Operating-System: FreeBSD 12.2-STABLE amd64 X-Host-Uptime: 7:18PM up 6 days, 17:39, 4 users, load averages: 0.43, 0.35, 0.27 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 18:24:00 -0000 Hi Mark, is this change not a little bit to aggressive in terms of dmesg cleanup? There are a lot messages about what subsystem is initialized with how many threads, like for example TCP HTPS and TCP BBR. Hiding this information could be suboptimal for some users. --Gordon On Fri, Mar 05, 2021 at 06:15:13PM +0000, Mark Johnston wrote: > The branch main has been updated by markj: > > URL: https://cgit.FreeBSD.org/src/commit/?id=89b650872bba2e4bfbc94a200946b461ef69ae22 > > commit 89b650872bba2e4bfbc94a200946b461ef69ae22 > Author: Mark Johnston > AuthorDate: 2021-03-05 18:11:02 +0000 > Commit: Mark Johnston > CommitDate: 2021-03-05 18:11:02 +0000 > > ktls: Hide initialization message behind bootverbose > > We don't typically print anything when a subsystem initializes itself, > and KTLS is currently disabled by default anyway. > > Reviewed by: jhb > MFC after: 1 week > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D29097 > --- > sys/kern/uipc_ktls.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sys/kern/uipc_ktls.c b/sys/kern/uipc_ktls.c > index 5125061e0879..1fd1eca39b59 100644 > --- a/sys/kern/uipc_ktls.c > +++ b/sys/kern/uipc_ktls.c > @@ -495,7 +495,8 @@ ktls_init(void *dummy __unused) > } > } > > - printf("KTLS: Initialized %d threads\n", ktls_number_threads); > + if (bootverbose) > + printf("KTLS: Initialized %d threads\n", ktls_number_threads); > } > SYSINIT(ktls, SI_SUB_SMP + 1, SI_ORDER_ANY, ktls_init, NULL); > > _______________________________________________ > dev-commits-src-main@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main > To unsubscribe, send any mail to "dev-commits-src-main-unsubscribe@freebsd.org" --