From owner-svn-src-all@freebsd.org Thu Mar 29 01:12:38 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B6F3F5EDCD for ; Thu, 29 Mar 2018 01:12:38 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x22d.google.com (mail-yb0-x22d.google.com [IPv6:2607:f8b0:4002:c09::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 598BF6DF88 for ; Thu, 29 Mar 2018 01:12:37 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x22d.google.com with SMTP id e3-v6so1467645ybk.1 for ; Wed, 28 Mar 2018 18:12:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=S7KGwFJArH2O26+jC+XjRuiCIgydaPpVQQ+I2Wkp8rU=; b=VVVLucoFwO0BxaqAXvDjBnjjXVN+nFm0u9x/qP2DQiIQb7OY1iS8izBzvW+TPvoiz+ Hxk5Z0dRJ9PB5+bCUKYKkAwJSBXPGMOoNichQ+WYxRQuQe4GcQzlsQSsIXF8QO/e5P+F D/PnCQybdFp2w6JyXXSax2gWYTWquKHgjciMg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=S7KGwFJArH2O26+jC+XjRuiCIgydaPpVQQ+I2Wkp8rU=; b=X8a87OYoqznQiDjVVCoP66c4IFHSwcWAWyo4SoNxc5h7z+GH4jDH7+W/f/nE8e8qsg 0sDle7FwWvKiGHLCrjjgqtzqyIvZErxgBJd7yJr5SV0oRckKonvdAQS4DcX2xG5MCmqo z9ORktu6kJZ5fHbQUhe+Qb31thboTJByZjao+szf+g/ZPBMIZK1YRtUew59y/Z3vvQ9y ziVOs39ZnmJaXTOuTUXSwwshDHkRaeqmwTfmTTTe/bxs2q/IXOLrxQ46FznIT0sqJgah GcQfJ20vrw5Oa+oQ0uiuwbsrdtazAjjggyKEAGLsX3flaBR+pYDGigGaoCwRPEQCUeL0 QC9Q== X-Gm-Message-State: AElRT7Hwc7OBKPfu5BQ1T36qjeMJfonqRLGUir16p0R0NDXPfmcQhDp1 mhDUb4jS6jVCttR86eVH+7wq37YG/qFvGmVU/527DQ== X-Google-Smtp-Source: AIpwx4899V1fKsyaPTMngDJefMptgO2cEkJYvEIQmB1IWhw4ZANhUjux9t2m5Jx9/xKmIUkwNtt6tF1KvqLhdaIP5jM= X-Received: by 2002:a25:40ca:: with SMTP id n193-v6mr3634765yba.89.1522285956562; Wed, 28 Mar 2018 18:12:36 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 2002:a5b:990:0:0:0:0:0 with HTTP; Wed, 28 Mar 2018 18:12:06 -0700 (PDT) In-Reply-To: References: <201803140319.w2E3JuGP036341@repo.freebsd.org> From: Eitan Adler Date: Wed, 28 Mar 2018 18:12:06 -0700 X-Google-Sender-Auth: Zdy8-Pzb4N2qrxxERuPqT5f60IY Message-ID: Subject: Re: svn commit: r330897 - in stable/11: bin/cat bin/chflags bin/chmod bin/cp bin/date bin/dd bin/df bin/domainname bin/echo bin/ed bin/hostname bin/kill bin/ln bin/ls bin/mkdir bin/mv bin/pax bin/ps bi... To: Allan Jude Cc: Oliver Pinter , "Conrad E. Meyer" , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 01:12:38 -0000 On 28 March 2018 at 18:04, Allan Jude wrote: > On 2018-03-28 14:15, Oliver Pinter wrote: >> Hi! >> >> This part of the MFC is wrong: >> >> https://svnweb.freebsd.org/base/stable/11/sys/sys/random.h?limit_changes=0&r1=330897&r2=330896&pathrev=330897 >> >> Could you please MFC back the other random related changes too? Some >> of them made by cem@. >> >> On 3/14/18, Eitan Adler wrote: >>> Author: eadler >>> Date: Wed Mar 14 03:19:51 2018 >>> New Revision: 330897 >>> URL: https://svnweb.freebsd.org/changeset/base/330897 >>> >>> Log: >>> Partial merge of the SPDX changes >>> >>> These changes are incomplete but are making it difficult >>> to determine what other changes can/should be merged. >>> >>> No objections from: pfg >>> > Am I missing something? If this MFC was supposed to be of the SPDX > license tagging, why does it have any functional changes? > > Especially changes to random(4)? This was my failure. I only spot checked & compile-checked the diff since I expected all changes to be comments/SPDX. However, I must have gotten carried away and included a few too many revisions. Unfortunately some people have already merged fixes to my failure and thus this can't be reverted as is without also reverting those fixes. That said, I should do that since this commit message is utterly wrong. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams