From owner-svn-src-all@freebsd.org Sat Feb 16 04:55:30 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1A53614D1B17; Sat, 16 Feb 2019 04:55:30 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 81B6B7262D; Sat, 16 Feb 2019 04:55:29 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x533.google.com with SMTP id m2so3529229pgl.5; Fri, 15 Feb 2019 20:55:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cvWkDYo4kGKEn3aLTk+x0e0T1A4qac9V7BvZiGVY1MI=; b=oGxLDKlQ0Sm5YlziSVSDIVYzBv8r7FINdb9w8NHw5HwNMmCjNyMLVeSsIuqfSCNYNd qFQXy01GyVL/3c8Vj724nuJDBAO8HYHSU3ufWfPnS87IZ5xpLwHN4t9NL/oQ7RHtFaMU /WHEhf3ExmMYIrR4+I5FcFajCbIIJ370q3xjzhVC/OsOH0DEdYBbCsKkrNS6I3Ca/Adg 2/sa0qmW/LSgs5tdI3ajYrqBzsSxU/Jou3fFphfG6PnuIjwHnXIOSClxC+3CJOtTaKzw 4CANmu3qIDd5Ac0kAKuvFxypWHvEkzwfVJZhP07uTL4x34o6Sll86vbuDMWGC7Ocybev q1OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cvWkDYo4kGKEn3aLTk+x0e0T1A4qac9V7BvZiGVY1MI=; b=uQX8MtvKn7rrlW32fEcQXjanysWP1nXP5jKSz0SUOZeBzAvQ63Jlhk42hb6UpKrgF3 1UcG9UkrMaKHMmEjHmFbX3JIwNnq2FQqBn/CKF8xZIzFLISL2R9yEWveiXiyFkupH4S9 772gLK9N44qlxksmN5CFyV8oNtRwKsZCE28tQXiawJXMgDYoBY5sJrlunjY+RoqUuKoG 7xFGLfvp02WwqlduNzpVcsrBtj1OrvZzmlP2YS0poaTDPLZZcranRTwUS0uYZEIUtIsr A841xqD1DANiBCoJnKXJ7rOKoZ5B1m9IuDm8/znaIQAmEa8o4Gv3sQnXfGDT1HhwgXJT j9Jw== X-Gm-Message-State: AHQUAubz94TZBGTlxJKBOds3jeTPBZPTNF0/+F6jOdGn9j8qfiRASGVK Z93uUHj61CKa3KUwSVfZUVIehL0e X-Google-Smtp-Source: AHgI3IY2C4M5BqjVGv3WyU9/rpuG3QT4exojm9Zjj3PClo0dq7RaVlB02iN4TfY9rIFYto3xWMvQuw== X-Received: by 2002:a63:3703:: with SMTP id e3mr8559638pga.348.1550292927926; Fri, 15 Feb 2019 20:55:27 -0800 (PST) Received: from [192.168.20.22] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id y129sm15825396pfy.102.2019.02.15.20.55.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 20:55:27 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r344191 - head/sbin/nvmecontrol From: Enji Cooper X-Mailer: iPhone Mail (16C104) In-Reply-To: <201902160015.x1G0F3EJ060777@repo.freebsd.org> Date: Fri, 15 Feb 2019 20:55:26 -0800 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201902160015.x1G0F3EJ060777@repo.freebsd.org> To: Warner Losh X-Rspamd-Queue-Id: 81B6B7262D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.94)[-0.939,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Feb 2019 04:55:30 -0000 > On Feb 15, 2019, at 16:15, Warner Losh wrote: >=20 > Author: imp > Date: Sat Feb 16 00:15:02 2019 > New Revision: 344191 > URL: https://svnweb.freebsd.org/changeset/base/344191 >=20 > Log: > Remove write-only s_flag. >=20 > Modified: > head/sbin/nvmecontrol/firmware.c >=20 > Modified: head/sbin/nvmecontrol/firmware.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sbin/nvmecontrol/firmware.c Fri Feb 15 23:46:34 2019 (r3441= 90) > +++ head/sbin/nvmecontrol/firmware.c Sat Feb 16 00:15:02 2019 (r3441= 91) > @@ -177,7 +177,7 @@ static void > firmware(const struct nvme_function *nf, int argc, char *argv[]) > { > int fd =3D -1, slot =3D 0; > - int a_flag, s_flag, f_flag; > + int a_flag, f_flag; > int activate_action, reboot_required; > int opt; > char *p, *image =3D NULL; > @@ -188,7 +188,7 @@ firmware(const struct nvme_function *nf, int argc, cha= > uint8_t fw_slot1_ro, fw_num_slots; > struct nvme_controller_data cdata; >=20 > - a_flag =3D s_flag =3D f_flag =3D false; > + a_flag =3D f_flag =3D false; >=20 > while ((opt =3D getopt(argc, argv, "af:s:")) !=3D -1) { Hi Warner! Should =E2=80=9Cs:=E2=80=9D be removed here, along with any correspondin= g documentation about =E2=80=98-s foo=E2=80=99? Thanks so much! -Enji=