From owner-svn-src-head@freebsd.org Sun Nov 5 16:30:23 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 082A1E37745; Sun, 5 Nov 2017 16:30:23 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C56A9136E; Sun, 5 Nov 2017 16:30:22 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 00D4F827; Sun, 5 Nov 2017 16:30:22 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 16F6E5164; Sun, 5 Nov 2017 16:30:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id qS2Gg_x5ZYRv; Sun, 5 Nov 2017 16:30:17 +0000 (UTC) Subject: Re: svn commit: r325404 - head/share/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 78139515F To: "Simon J. Gerraty" Cc: "O. Hartmann" , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Cy Schubert References: <201711042102.vA4L2RuR063978@repo.freebsd.org> <20171104223133.00f5bf30@thor.intern.walstatt.dynvpn.de> <20171105111644.4c294342@thor.intern.walstatt.dynvpn.de> <7d0c021d-fe3d-9bea-b088-5e530176288b@FreeBSD.org> <13707.1509899195@kaos.jnpr.net> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <0b1ad34d-bc2f-c0fb-5ed3-68d07f4a7aac@FreeBSD.org> Date: Sun, 5 Nov 2017 08:30:20 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <13707.1509899195@kaos.jnpr.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QNokupXj5FohTNa4AmPgigvakF7NgGPWX" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Nov 2017 16:30:23 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QNokupXj5FohTNa4AmPgigvakF7NgGPWX Content-Type: multipart/mixed; boundary="T9L9mboiQXoHsEmc0EVPFO9rBvo7FhW9h"; protected-headers="v1" From: Bryan Drewery To: "Simon J. Gerraty" Cc: "O. Hartmann" , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Cy Schubert Message-ID: <0b1ad34d-bc2f-c0fb-5ed3-68d07f4a7aac@FreeBSD.org> Subject: Re: svn commit: r325404 - head/share/mk References: <201711042102.vA4L2RuR063978@repo.freebsd.org> <20171104223133.00f5bf30@thor.intern.walstatt.dynvpn.de> <20171105111644.4c294342@thor.intern.walstatt.dynvpn.de> <7d0c021d-fe3d-9bea-b088-5e530176288b@FreeBSD.org> <13707.1509899195@kaos.jnpr.net> In-Reply-To: <13707.1509899195@kaos.jnpr.net> --T9L9mboiQXoHsEmc0EVPFO9rBvo7FhW9h Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/5/2017 8:26 AM, Simon J. Gerraty wrote: > Bryan Drewery wrote: >>> ${.OBJDIR} =3D=3D /${RELDIR})) make[6]: Fatal errors encountered -- c= annot continue make[6]: >>> stopped >>> in /usr/obj/usr/src/amd64.amd64/sys/THOR/usr/ports/emulators/virtualb= ox-ose-kmod/work/VirtualBox-5.2.0/out/freebsd.amd64/release/bin/src/vboxd= rv >>> *** Error code 1 >> >> Weird, can you try this please? http://dpaste.com/3HR1EQH.txt >> >=20 > That will work, but you could remove the check for SRCTOP since it isn'= t > used in the conditional. >=20 > FWIW this is happening because make is being run from within OBJTOP > during kernel module build, and thus the logic in src.sys.env.mk > isn't defining RELDIR. >=20 > If OBJTOP were defined (it is in my case) the following > which is similar to what we have in our internal trees > would fix it. >=20 > In the FreeBSD tree though OBJTOP may not defined until some time later= =2E > And if you want to .export it you need to use .export-env and play game= s > to get it into a form that will work as TARGET_SPEC_VARS change values.= >=20 > Index: share/mk/src.sys.env.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- share/mk/src.sys.env.mk (revision 325436) > +++ share/mk/src.sys.env.mk (working copy) > @@ -10,6 +10,8 @@ > RELTOP=3D . > .elif ${.CURDIR:M${SRCTOP}/*} > RELDIR:=3D ${.CURDIR:S,${SRCTOP}/,,} > +.elif ${.CURDIR:M${OBJTOP}/*} > +RELDIR:=3D ${.CURDIR:S,${OBJTOP}/,,} > .endif > RELTOP?=3D ${RELDIR:C,[^/]+,..,g} > RELOBJTOP?=3D ${RELTOP} >=20 I only find RELDIR useful in the non-kernel builds, so I don't really care to extend it here. --=20 Regards, Bryan Drewery --T9L9mboiQXoHsEmc0EVPFO9rBvo7FhW9h-- --QNokupXj5FohTNa4AmPgigvakF7NgGPWX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZ/zydAAoJEDXXcbtuRpfPQn4IANSOUvYWoR/Ek+AGO2LTZWZ2 rZx7lDCDezHMUEeHVVIaHpCHVx0FNrfVi7TnsScyO8ps/jb8pzk+jFW0JXabAeAg 8s4bafwTJnimzNIXcBQzmOcPae+lXeFoDXRi/6SN+zsfWGrnTsMp/NCx8feursVO V8IRCdieigk7mMbZN4O7EO/lnrn0iNJuhWpI0XsdlMwF26+FYkI1FwfijFj9PUjA IPWMcsU6C6tDf0+BoVPxMUWymHCam39P+vgKtPnX0c9oZQNQ+ng/4xXVZMj8//Ce Ztp0yqOLxDFFfvx6tenMJOF9t3gwbsgu0Z9b626TWcjeuRqUIeRo6EunXEFWV40= =zLf9 -----END PGP SIGNATURE----- --QNokupXj5FohTNa4AmPgigvakF7NgGPWX--