From owner-svn-src-all@freebsd.org Sat May 25 02:41:24 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2E9B15955EC; Sat, 25 May 2019 02:41:24 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 186E989F84; Sat, 25 May 2019 02:41:24 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-lf1-x142.google.com with SMTP id d8so8425431lfb.8; Fri, 24 May 2019 19:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Aq463CB5WCkNULTebLHQFwkUKCD0T5HlnJ314ndE9uY=; b=a1eL4Vw1watZCw/5n2lbmoKatPcBjShoLTl32RBaISJykAuvsLk920QWRFxE2ongaO mgjH5XO7y8ARcHBDEi9ACZsVlzmfAD/cm7tcd0YK6bOBlcwtt757fNqpOwuIoTDgnH0/ 5d8l0BT0dEZcYatW1j89aqf85MTrjk7XOuT5dkiIXSdHRC1lCZnSaEavRezKG5Oz6vhh zivqUTXO0fRVcz7lwZpSSaleFjHGCsfqQgShPQyIWJE6AjtxDhAEIpjJUKOffhDf6dHb ITYI2T8wsujbnqpvWS9kKJRUeSLIDPyFHcSAHrrb4UiYwhshNyp5ERNTodPNVAZy11Pz iDGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Aq463CB5WCkNULTebLHQFwkUKCD0T5HlnJ314ndE9uY=; b=WbnkpEXP6zVxa5GO4Cd5ac7b0XKvAh6Rfbp8Q6REaCD0eVqJoycRsUhrv19l3GyigI DtzgyNXn92Pf25xSx+Na9xOTI9oIXp3R2mjn0cG13nukP7H1Hq4uXfeW7sgL1Y2jo/06 vvSTRsS8fWb0YcPdP9AhC3g6ZrsocuICLYbrLnXibgvpPOakKP9asYOHJ0DAYUx7Nce/ BO/B+ozSXtCXGtgYMymt6jAfpWLyDwgXEQDCKzfEI3T76jFFTFJX6P54P0Q1CJHB+mu7 BWp/oSIXoN6caP6isulbKgh85jshezvDswGhdDZJ/qnfsXzmuhBBsxKjwhKnTr2572vY IjLg== X-Gm-Message-State: APjAAAVetfhXxNGfapVo6llyh6aOb1CsQ9qIKu6f3/zUjcxoNWUGNtOb Ns2kO9B9wOhLlOK+ypB/pG451ZtUcdiegH4dJZj6UA7l X-Google-Smtp-Source: APXvYqwk8bcAgBtCIlEvXESTMLofTQFTnCmtnvVLNkg6o8Bc4ET7kO7wJPULEoSiwBEEydQ00ffFPAsDx6V1m1gxmYA= X-Received: by 2002:a19:f60f:: with SMTP id x15mr1748453lfe.61.1558752080584; Fri, 24 May 2019 19:41:20 -0700 (PDT) MIME-Version: 1.0 References: <20190524152941.40f7e239@titan.knownspace> <201905242301.x4ON1Zju098365@gndrsh.dnsmgr.net> In-Reply-To: <201905242301.x4ON1Zju098365@gndrsh.dnsmgr.net> From: Justin Hibbits Date: Fri, 24 May 2019 21:41:08 -0500 Message-ID: Subject: Re: svn commit: r348250 - head/sys/powerpc/conf To: rgrimes@freebsd.org Cc: Alexey Dokuchaev , Piotr Kubaj , svn-src-head , svn-src-all , src-committers Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 186E989F84 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 May 2019 02:41:24 -0000 On Fri, May 24, 2019 at 6:01 PM Rodney W. Grimes wrote: > > > On Fri, 24 May 2019 20:22:52 +0000 > > Alexey Dokuchaev wrote: > > > > > On Fri, May 24, 2019 at 03:16:51PM -0500, Justin Hibbits wrote: > > > > On Fri, 24 May 2019 20:01:59 +0000 (UTC) Piotr Kubaj wrote: > > > > > New Revision: 348250 > > > > > URL: https://svnweb.freebsd.org/changeset/base/348250 > > > > > > > > > > Log: > > > > > Add snd_hda(4) to GENERIC64 used by powerpc64. > > > > > > > > > > amd64 also has snd_hda(4) in GENERIC. > > > > > > > > > > Modified: > > > > > head/sys/powerpc/conf/GENERIC64 > > > > > ... > > > > > > > > To note: This was done because there's a strange bug in the snd_hda > > > > module, with the hdaa component. For some reason it either doesn't > > > > find all the internal components it needs, or something, because > > > > there's a NULL dereference when trying to call a kobj method in > > > > hdaa_attach(). > > > > > > So this commit essentially masks the real bug somewhere rather than > > > fixing it, is this what you're saying? > > > > > > ./danfe > > > > It's a viable workaround to a problem that reaches a wide audience. > > Since it works built-in, I found it acceptable. I probably should have > > filed a bug for it a year ago when I hit it and worked around it, but it > > could also very well be a compiler issue. > > > > By the way, it works fine on powerpc (32-bit) loaded as a module. > > Please do file a bug report now, please do mark the line in GENERIC64 with > a comment XXX This is needed to work around foo so that it is documented > why it is there and someone removing it does not go down a rabit > hole others have already been down, and so that some day someone > may go down that rabbit hole of there own free will and fix this > for us. > > Paving over the top of obscure bugs with a hackish fix is ok, > not documenting this state of affairs is not, IMHO. > > > - Justin > -- > Rod Grimes rgrimes@freebsd.org Bug filed as kern/238113. I don't think a XXX is necessarily needed in GENERIC64, since it's also parity with GENERIC on amd64. - Justin