From owner-freebsd-perl@FreeBSD.ORG Tue Feb 14 19:59:29 2006 Return-Path: X-Original-To: freebsd-perl@freebsd.org Delivered-To: freebsd-perl@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A6FDE16A433 for ; Tue, 14 Feb 2006 19:59:29 +0000 (GMT) (envelope-from paul+fbsd@it.ca) Received: from mail2.dm.egate.net (mail2.dm.egate.net [216.235.1.136]) by mx1.FreeBSD.org (Postfix) with ESMTP id 423A343D49 for ; Tue, 14 Feb 2006 19:59:27 +0000 (GMT) (envelope-from paul+fbsd@it.ca) Received: from mail.it.ca (root@[216.235.7.67]) by mail2.dm.egate.net (8.12.11/8.12.10) with ESMTP id k1EJxQHZ041039 for ; Tue, 14 Feb 2006 14:59:26 -0500 (EST) (envelope-from paul+fbsd@it.ca) Received: from mail.it.ca (paul@mail [216.235.7.67]) by mail.it.ca (8.13.3/8.13.3) with ESMTP id k1EJxGNR002333 for ; Tue, 14 Feb 2006 14:59:16 -0500 (EST) (envelope-from paul+fbsd@it.ca) Received: (from paul@localhost) by mail.it.ca (8.13.3/8.13.3/Submit) id k1EJxGms002332 for freebsd-perl@freebsd.org; Tue, 14 Feb 2006 14:59:16 -0500 (EST) (envelope-from paul+fbsd@it.ca) X-Authentication-Warning: mail.it.ca: paul set sender to paul+fbsd@it.ca using -f Date: Tue, 14 Feb 2006 14:59:16 -0500 From: Paul Chvostek To: freebsd-perl@freebsd.org Message-ID: <20060214195916.GA1400@it.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.11 Subject: the PERL make variable... X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: freebsd-perl@freebsd.org List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2006 19:59:29 -0000 Hiya. I posted this to freebsd-ports a few days ago and got no response. Perhaps someone here can lend an opinion. On a number of occasions in the past, when creating ports of Perl scripts, I've included a make target with something like: post-patch: @${SED} '1s:/usr/bin/perl:${PERL}:' < ${_DISTDIR}${DISTFILES} > ${WRKSRC}/... Most of these were originally submitted back in 4.x days, when PERL was often /usr/local/bin/perl. The handbook and bsd.port.mk are clear that the variable should be used for shell magic. But I submitted two new ports last week had this use of PERL removed upon commit. The committer claimed he didn't the purpose of the PERL make variable, and that pointing to the perl binary at /usr/bin/perl was the best way to go. Almost 2000 ports use the PERL variable, and I haven't seen any announcements indicating that it was going away. Was the committer who handled my ports just a little too eager to shrink the Makefiles? :) At this point, the ports are in, missing the post-patch target. Should they stay as-is, or I submit a change, or let them be until after the upcoming release? p -- Paul Chvostek it.canada, hosting and development http://www.it.ca/