From owner-freebsd-net Mon Sep 24 8:24:58 2001 Delivered-To: freebsd-net@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 1804237B41A for ; Mon, 24 Sep 2001 08:24:53 -0700 (PDT) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.5) with SMTP id f8OFOcB67483; Mon, 24 Sep 2001 11:24:38 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Mon, 24 Sep 2001 11:24:38 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: "Matthew N. Dodd" Cc: freebsd-net@freebsd.org Subject: Re: review request. In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org I'd be happy to see a KASSERT() dropped in there--the type of bug this is probably intended to address is a reversed set of procedures during interface cleanup, or multiple invocation. In SMPng, the failure modes for this kind of error situation will be a lot less forgiving (especially with regards to potential races), and as such we want to find those failures early, rather than let them slip through. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services On Sun, 23 Sep 2001, Matthew N. Dodd wrote: > sys/net/if.c and bpf.c have problems with if_detach() and > bpfdetach() when they are called with a struct ifnet that has not had > if_attach() and bpfattach() called on it. Null pointer reference -> > *boom* etc. > > This patch fixes the test already present in bpfdetach() and adds a test > to if_detach(). > > Thanks. > > -- > | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | > | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | > | http://www.jurai.net/~winter | For Great Justice! | ISO8802.5 4ever | > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message