From owner-freebsd-geom@FreeBSD.ORG Thu Dec 5 08:26:07 2013 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CCE4F54A for ; Thu, 5 Dec 2013 08:26:07 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 52FED173A for ; Thu, 5 Dec 2013 08:26:07 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id rB58PuGs019685; Thu, 5 Dec 2013 10:25:56 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua rB58PuGs019685 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id rB58Puf4019683; Thu, 5 Dec 2013 10:25:56 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 5 Dec 2013 10:25:56 +0200 From: Konstantin Belousov To: Paolo Pinto , nicolas dumont , freebsd-geom@freebsd.org Subject: Re: geom_uzip, panic: bio_length in mdstart_vnode() Message-ID: <20131205082556.GA59496@kib.kiev.ua> References: <529F2748.2060900@netasq.com> <20131204162029.GV59496@kib.kiev.ua> <20131205020742.GU55638@funkthat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LStQImaUpO8G1Pdp" Content-Disposition: inline In-Reply-To: <20131205020742.GU55638@funkthat.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Dec 2013 08:26:07 -0000 --LStQImaUpO8G1Pdp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 04, 2013 at 06:07:43PM -0800, John-Mark Gurney wrote: > Konstantin Belousov wrote this message on Wed, Dec 04, 2013 at 18:20 +020= 0: > > On Wed, Dec 04, 2013 at 01:59:52PM +0100, Paolo Pinto wrote: > > > Hi list! > > >=20 > > > My kernel is compiled with option INVARIANTS and I get a reproducible > > > kernel panic when trying to read data from a GEOM based compressed > > > memory disk: > > >=20 > > > Unread portion of the kernel message buffer: > > > panic: bio_length 140288 > > > cpuid =3D 3 > > > KDB: stack backtrace: > > > #0 0xffffffff80909726 at kdb_backtrace+0x66 > > > #1 0xffffffff808d0fa8 at panic+0x1d8 > > > #2 0xffffffff80595949 at mdstart_vnode+0x619 > >=20 > > The issue is that geom_uzip creates bios which are larger than MAXPHYS. >=20 > Shouldn't geom_uzip be fixed to honor MAXPHYS? By all means, fix it. >=20 > > As a workaround, the following patch should be enough. It only fires > > assert when md really uses pbuf, and since geom_uzip knows nothing > > about unmapped bio, the assertion must not trigger. >=20 > Ummm... what's the point of MAXPHYS if we allow IO larger than it? This is rhetorical question, right ? --LStQImaUpO8G1Pdp Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJSoDiTAAoJEJDCuSvBvK1BGcwP/Rocdfagi0MjGmqknHJC3Xg2 X/nG0tr6nY/sga7Hbsip5v/jwp9wt3Pfd3v1q6UQ2qPQgNR+Gbs+4XHnLuFf/Ap1 8YZRn7lvVJ/jEZY8OeM/srOOlEddC9oOPTTQ0XIgpP5z3rlSHiy+8ab+s+suS1X1 H25Fhr9gkNFwNWl489+oitzJldfjp0/7oY2jIaIy4jzTAiwCUuz8hBUbeVZxXM0Y K8KGlsWdgSRWh9JmPKKTr6ycGYxwKkysktwQ+fKXRtm8j/3pQ1fJ11vRLDopDM8d +oj+s075rzylrcLlrrLiUtOZ6ykTZ7RQ3YPQkw5AikbBtFq2xP/jyQRpNKahzED4 vY5FhbH9OFuURb9n2AAtv0YWy/sCl2SmZLI3CkmmhVE8IBLdB/fWBUFGCwhNeyHZ 6J8ZU3jAXoFGcXfEzkJYULYnnPyrOeFp2TJuogjHRA/AUDwoWG5uDjtzjyKLJYBj WY5NiDCn8CpLACX1xw3VjHUBP2Y2OTITUMl5gaicQWd7YzORae1Lf6y3YkzTj627 s0mHwnSGVYvODhuQTav3NwOTitwEuf49q8QrpQ3QDX2ylSnd/WMF3Vf3nuA8pxTk jmNl58/mXSAl7i5ynv3b1+H3vbx2qYjny9nhvKFKwDb3VZVpJS3dUP8/QRK1/H2T OJLBJlwJdEyaVZv0m/ST =MGua -----END PGP SIGNATURE----- --LStQImaUpO8G1Pdp--