From owner-freebsd-current@FreeBSD.ORG Fri Aug 20 19:17:33 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A0A9C16A4CE for ; Fri, 20 Aug 2004 19:17:33 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4817443D1D for ; Fri, 20 Aug 2004 19:17:33 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i7KJFPWa052254; Fri, 20 Aug 2004 15:15:25 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i7KJFPgZ052251; Fri, 20 Aug 2004 15:15:25 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Fri, 20 Aug 2004 15:15:25 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Gordon Bergling In-Reply-To: <20040820183544.GA986@nemesis.md.0xfce3.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-current@freebsd.org Subject: Re: [5.3-ALPHA] Panic in in6_pcb.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Aug 2004 19:17:33 -0000 On Fri, 20 Aug 2004, Gordon Bergling wrote: > I recently got a panic with the following output: > > | panic: lock (sleep mutex) inp not locked @ > | /usr/src/sys/netinet6/in6_pcb.c:710 > > System is a fresh 5.3-ALPHA running on an idle workstation. Just a few > console applications were running in the background. > > I haven't get my hands on a coredump yet, but if someone is interested > in it I could provide further information. Is this something you can reproduce? The attached patch was created when Jun Kuriyama ran into the same panic a few days ago, but he wasn't sure if he could reproduce it. If you could test it and let me know, that would be great, thanks! Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research Index: in6_pcb.c =================================================================== RCS file: /home/ncvs/src/sys/netinet6/in6_pcb.c,v retrieving revision 1.59 diff -u -r1.59 in6_pcb.c --- in6_pcb.c 14 Aug 2004 15:32:20 -0000 1.59 +++ in6_pcb.c 18 Aug 2004 04:02:00 -0000 @@ -705,9 +705,11 @@ } do_notify: - if (notify) - (*notify)(inp, errno); - INP_UNLOCK(inp); + if (notify) { + if ((*notify)(inp, errno)) + INP_UNLOCK(inp); + } else + INP_UNLOCK(inp); } INP_INFO_WUNLOCK(pcbinfo); splx(s);