From owner-cvs-src@FreeBSD.ORG Mon Mar 12 19:54:38 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 348CF16A401; Mon, 12 Mar 2007 19:54:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id CB61313C45D; Mon, 12 Mar 2007 19:54:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l2CJsYSL064108; Mon, 12 Mar 2007 14:54:36 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Attilio Rao" Date: Mon, 12 Mar 2007 15:39:26 -0400 User-Agent: KMail/1.9.1 References: <200703092241.l29Mf2Ds062856@repoman.freebsd.org> <200703121114.59859.jhb@freebsd.org> <3bbf2fe10703120936w1909c744uc36ca1c030e76b6@mail.gmail.com> In-Reply-To: <3bbf2fe10703120936w1909c744uc36ca1c030e76b6@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703121539.27016.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 12 Mar 2007 14:54:36 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2825/Mon Mar 12 12:11:35 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Pawel Jakub Dawidek , cvs-all@freebsd.org Subject: Re: cvs commit: src/share/man/man9 Makefile condvar.9 lock.9 mi_switch.9 mtx_pool.9 mutex.9 rwlock.9 sleep.9 sleepqueue.9 sx.9 thread_exit.9 src/sys/kern kern_synch.c src/sys/sys mutex.h rwlock.h sleepqueue.h sx.h systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2007 19:54:38 -0000 On Monday 12 March 2007 12:36, Attilio Rao wrote: > > So you still get type checking, etc. I'm thinking maybe the simplest thing to > > do is to rename 'mtx_object', 'rw_object', and 'sx_object' fields to all > > be 'lock_object' and then do this: > > Even if this idea is not so bad (beacause we primitives are in a small > and controlled number of them) we have a lot of places to update for > that. A macro could be a temporary help, btw. They are actually not very widespread at all, most uses are in macros in the headers or in the lock code itself. Nothing M-% in xemacs can't handle. :) % kgrep -l -E '(mtx|rw|sx)_object' kern/kern_condvar.c kern/kern_exit.c kern/kern_kse.c kern/kern_sig.c kern/kern_lock.c kern/kern_mutex.c kern/kern_rwlock.c kern/kern_sx.c kern/kern_synch.c kern/subr_witness.c sys/_mutex.h sys/_rwlock.h sys/lock.h sys/mutex.h sys/rwlock.h sys/sx.h sys/proc.h sys/systm.h -- John Baldwin