From owner-cvs-all@FreeBSD.ORG Fri Nov 18 09:10:47 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 043A916A41F; Fri, 18 Nov 2005 09:10:47 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B86B442F0; Fri, 18 Nov 2005 09:10:45 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from Andro-Beta.Leidinger.net (p54A5E4F3.dip.t-dialin.net [84.165.228.243]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.1/8.13.1) with ESMTP id jAI8kXVc075574; Fri, 18 Nov 2005 09:46:34 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from localhost (localhost [127.0.0.1]) by Andro-Beta.Leidinger.net (8.13.3/8.13.3) with ESMTP id jAI9Adw5064654; Fri, 18 Nov 2005 10:10:39 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Fri, 18 Nov 2005 10:10:38 +0100 Message-ID: <20051118101038.7ri7aj55nkk08wgw@netchild.homeip.net> X-Priority: 3 (Normal) Date: Fri, 18 Nov 2005 10:10:38 +0100 From: Alexander Leidinger To: Stefan Farfeleder References: <200511150419.jAF4JRUp080869@repoman.freebsd.org> <20051115105128.a5dd001i0ckock0s@netchild.homeip.net> <20051115095801.M61850@fledge.watson.org> <20051115202306.4cf2dcf2.ariff@FreeBSD.org> <20051115124331.GD9996@wombat.fafoe.narf.at> <20051117145139.h0rxsukk74wog4c8@netchild.homeip.net> <20051117143506.GL584@wombat.fafoe.narf.at> In-Reply-To: <20051117143506.GL584@wombat.fafoe.narf.at> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.0.3) / FreeBSD-4.11 X-Virus-Scanned: by amavisd-new Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Ariff Abdullah Subject: Re: cvs commit: src/sys/dev/sound/pcm channel.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2005 09:10:47 -0000 Stefan Farfeleder wrote: > On Thu, Nov 17, 2005 at 02:51:39PM +0100, Alexander Leidinger wrote: >> Stefan Farfeleder wrote: >> >> >On Tue, Nov 15, 2005 at 08:23:06PM +0800, Ariff Abdullah wrote: >> >>On Tue, 15 Nov 2005 09:58:52 +0000 (GMT) >> >>Robert Watson wrote: >> >> >>> Probably a combination of -Wall and -Werror, which generally >> >>> generates a warning along the following lines: >> >>> >> >>> warning: suggest parentheses around comparison in operand of & >> >>> >> >>That means, warnings caused by excessive inlining while compiling >> >>maestro.c should also break the build if WARNS=1, right? Has anybody >> >>encounter and getting annoyed by this? >> > >> >No, function inlining doesn't change the semantics of expressions. > > I misread Ariff's question. Please disregard. Ok. >> So -Wall and -Werror doesn' result in issuing an error for each warning but >> instead in an error for warnings, which are issued because the code in >> question may change the semantic depending on the change which needs to be >> done to get rid of the warning? > > Whether GCC prints 'warning:' or 'error:' is not changed by -Werror. But the behavior of gcc is changed by -Werror: gcc aborts instead of generating an object file. > I'm not sure understand the second part of your question. The warning > is issued because a & b == c is parsed as a & (b == c). The second part was how gcc behaves, I think it behaves like: if -Werror && any_warning_generated: bail_out Your answer to the (misread) message from Ariff suggested: if -Werror && warning_because_of_possible_semantic_change: bail_out Since you misread the message, no need to answer (except I'm wrong). Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 Until Eve arrived, this was a man's world. -- Richard Amour