From owner-svn-src-all@freebsd.org  Fri Jun  8 04:59:58 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AF4BF100FFCB;
 Fri,  8 Jun 2018 04:59:58 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 52D52725DE;
 Fri,  8 Jun 2018 04:59:58 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (unknown [127.0.1.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by freefall.freebsd.org (Postfix) with ESMTPS id 2BCE0EF1E;
 Fri,  8 Jun 2018 04:59:58 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [172.31.3.2])
 by mail.xzibition.com (Postfix) with ESMTP id 6554B3D7;
 Fri,  8 Jun 2018 04:59:57 +0000 (UTC)
X-Virus-Scanned: amavisd-new at mail.xzibition.com
Received: from mail.xzibition.com ([172.31.3.2])
 by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new,
 port 10026)
 with LMTP id 9hlvPrByIwC9; Fri,  8 Jun 2018 04:59:55 +0000 (UTC)
Content-Type: text/plain;
	charset=utf-8
DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com CE38A3D4
Mime-Version: 1.0 (1.0)
Subject: Re: svn commit: r334617 - in head: . etc
From: Bryan Drewery <bdrewery@FreeBSD.org>
X-Mailer: iPhone Mail (15E302)
In-Reply-To: <201806041517.w54FHPn0072477@repo.freebsd.org>
Date: Fri, 8 Jun 2018 00:59:51 -0400
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <8BBE4E4C-0E5F-4920-B057-E6F939074448@FreeBSD.org>
References: <201806041517.w54FHPn0072477@repo.freebsd.org>
To: Brad Davis <brd@FreeBSD.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jun 2018 04:59:59 -0000


> On Jun 4, 2018, at 11:17, Brad Davis <brd@FreeBSD.org> wrote:
>=20
> Author: brd
> Date: Mon Jun  4 15:17:24 2018
> New Revision: 334617
> URL: https://svnweb.freebsd.org/changeset/base/334617
>=20
> Log:
>  Move /sys symlink creating out of etc/Makefile.
>=20
>  This is prep for etc/Makefile going away.
>=20
>  Approved by:    bapt (mentor)
>=20
> Modified:
>  head/Makefile.inc1
>  head/etc/Makefile
>=20

Aside from other objections, I don=E2=80=99t think /Makefile nor /Makefile.i=
nc1 should =E2=80=9Cown=E2=80=9D anything on the system and should only driv=
e the build or other general targets for users to interact with. Please put t=
his into something like /hier or better yet the existing directory handling t=
hat stuff /etc. (so a revert since simply moving everything to it via a rena=
me or rewrite seems silly)


> Modified: head/Makefile.inc1
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
> --- head/Makefile.inc1    Mon Jun  4 14:56:02 2018    (r334616)
> +++ head/Makefile.inc1    Mon Jun  4 15:17:24 2018    (r334617)
> @@ -1239,6 +1239,7 @@ distributeworld installworld stageworld: _installche=
ck
>        METALOG=3D${METALOG} ${IMAKE_INSTALL} ${IMAKE_MTREE} \
>        DISTBASE=3D/base DESTDIR=3D${DESTDIR}/${DISTDIR}/base \
>        LOCAL_MTREE=3D${LOCAL_MTREE:Q} distrib-dirs
> +    ${INSTALL_SYMLINK} usr/src/sys ${DESTDIR}/sys
> .endif
>    ${_+_}cd ${.CURDIR}; ${IMAKE} re${.TARGET:S/world$//}; \
>        ${IMAKEENV} rm -rf ${INSTALLTMP}
>=20
> Modified: head/etc/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
> --- head/etc/Makefile    Mon Jun  4 14:56:02 2018    (r334616)
> +++ head/etc/Makefile    Mon Jun  4 15:17:24 2018    (r334617)
> @@ -386,7 +386,6 @@ distrib-dirs: ${MTREES:N/*} distrib-cleanup .PHONY
>            ${METALOG.add} ; \
>    done; true
> .endif
> -    ${INSTALL_SYMLINK} usr/src/sys ${DESTDIR}/sys
> .if ${MK_NLS} !=3D "no"
>    set - `grep "^[a-zA-Z]" ${.CURDIR}/nls.alias`; \
>    while [ $$# -gt 0 ] ; do \
>=20