From owner-freebsd-current@freebsd.org Thu Nov 28 04:16:51 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D8A971C396A for ; Thu, 28 Nov 2019 04:16:51 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47NkqQ743cz42Pv; Thu, 28 Nov 2019 04:16:50 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-qt1-f195.google.com with SMTP id y10so27773494qto.3; Wed, 27 Nov 2019 20:16:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KABTs5Ezt1Lm63iNm70JOgks7EBX5sAKnzzuImMmZKw=; b=aHY8tTMm0qNmgvD+8w7gvG7SPYF4zPCjGHJthsfgFznDH7TN+vXhESfyoxCYdgP2Kz MCcQ46QRVrRvoNoDEzYdTSKMzzuypzkD/GQkNnApuDxAyi5nN1Bor2hjW0EZPg9SGADc LEOyEnNeW0rWA338OUbyc+ZmLZS+XVzgE4/qNk8tdYhblqPvxfyxAcaeOxTYFlww0zgo 4OC87mm3drdwybVLzU9r2xCrkIwcEq0399usGqX62lx7UM5KLJIeUIcJGw2taWA8l47M fnwdPovDJUsFfgLGPD3vHla/GSEO4Hh883XVRhJkjf/nIyd8V0O36ZcSt5pcu0OFzP0M kvzA== X-Gm-Message-State: APjAAAVOofDpUQaeCLxiXLsoW/CDTPLix8ZBdSizcU22av+zOd3St/Y3 oKm9IsSkcFYFajTxeqFwcdC+2eH0SAQ= X-Google-Smtp-Source: APXvYqy543ETQ69xt9PDYvUUMav5TV2AwHXrqWLCbah1xOXPHMJtQQ0RLFYZjSLdSQLDmpN9b96OYw== X-Received: by 2002:ac8:2598:: with SMTP id e24mr36009782qte.189.1574914609158; Wed, 27 Nov 2019 20:16:49 -0800 (PST) Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com. [209.85.222.177]) by smtp.gmail.com with ESMTPSA id i17sm8703816qtm.53.2019.11.27.20.16.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2019 20:16:49 -0800 (PST) Received: by mail-qk1-f177.google.com with SMTP id i3so21587762qkk.9; Wed, 27 Nov 2019 20:16:48 -0800 (PST) X-Received: by 2002:a37:bf82:: with SMTP id p124mr8338319qkf.337.1574914608673; Wed, 27 Nov 2019 20:16:48 -0800 (PST) MIME-Version: 1.0 References: <3e4daebb-cd5d-a9b3-daa1-d335f18e9ec8@protected-networks.net> In-Reply-To: From: Ryan Libby Date: Wed, 27 Nov 2019 20:16:37 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: SVN r355148/9 breaks build To: Michael Butler Cc: freebsd-current , jeff@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47NkqQ743cz42Pv X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rlibby@gmail.com designates 209.85.160.195 as permitted sender) smtp.mailfrom=rlibby@gmail.com X-Spamd-Result: default: False [-3.82 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[195.160.85.209.list.dnswl.org : 127.0.5.0]; RWL_MAILSPIKE_GOOD(0.00)[195.160.85.209.rep.mailspike.net : 127.0.0.18]; IP_SCORE(-1.82)[ip: (-3.95), ipnet: 209.85.128.0/17(-3.16), asn: 15169(-1.95), country: US(-0.05)]; FORGED_SENDER(0.30)[rlibby@freebsd.org,rlibby@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[rlibby@freebsd.org,rlibby@gmail.com] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Nov 2019 04:16:51 -0000 On Wed, Nov 27, 2019 at 7:23 PM Ryan Libby wrote: > > On Wed, Nov 27, 2019 at 6:44 PM Michael Butler > wrote: > > > > Something missing from a header here? > > > > Building /usr/obj/usr/src/amd64.amd64/sys/VM01/uma_core.o > > --- uma_core.o --- > > /usr/src/sys/vm/uma_core.c:1864:39: error: use of undeclared identifier > > 'sysctl___vm_uma' > > zone->uz_oid = SYSCTL_ADD_NODE(NULL, > > SYSCTL_STATIC_CHILDREN(_vm_uma), > > ^ > > /usr/src/sys/sys/sysctl.h:245:44: note: expanded from macro > > 'SYSCTL_STATIC_CHILDREN' > > #define SYSCTL_STATIC_CHILDREN(oid_name) > > (&sysctl__##oid_name.oid_children) > > ^ > > :154:1: note: expanded from here > > sysctl___vm_uma > > ^ > > /usr/src/sys/vm/uma_core.c:1864:15: error: assigning to 'struct > > sysctl_oid *' from incompatible type 'void' > > zone->uz_oid = SYSCTL_ADD_NODE(NULL, > > SYSCTL_STATIC_CHILDREN(_vm_uma), > > ^ > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 2 errors generated. > > *** [uma_core.o] Error code 1 > > > > imb > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > Ah, SYSCTL_NODE(_vm, OID_AUTO, uma, ...) is accidentally under > INVARIANTS and needs to move out. > > I'll patch this up in an hour if jeff or someone else doesn't beat me to it. Should be fixed in r355166. Thanks for the report.