From owner-freebsd-bugs@freebsd.org Tue Dec 8 16:28:59 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 65BFC4A5866 for ; Tue, 8 Dec 2020 16:28:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4Cr5Gg2FcLz4brT for ; Tue, 8 Dec 2020 16:28:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4B6E04A5B86; Tue, 8 Dec 2020 16:28:59 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B34D4A5B85 for ; Tue, 8 Dec 2020 16:28:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cr5Gg1bP5z4bjt for ; Tue, 8 Dec 2020 16:28:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 29F6B17438 for ; Tue, 8 Dec 2020 16:28:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0B8GSxTM028819 for ; Tue, 8 Dec 2020 16:28:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0B8GSx9i028818 for bugs@FreeBSD.org; Tue, 8 Dec 2020 16:28:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 251483] after upgrading from 12.1 to 12.2 the mfi driver crashes during boot Date: Tue, 08 Dec 2020 16:28:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ambrisko@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2020 16:28:59 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251483 --- Comment #6 from Doug Ambrisko --- I never figured out what this code was dealing with. It came from LSI/Avago/Broadcom with their initial support of Thunderbolt family of RAID cards. This was before they decided to make mrsas. That is why I put in t= he printf. I assume that the CLI was MegaCLI. Note that the MFI_CMD_PD_SCSI_= IO is for commands going to the raw disk versus to the RAID volume. This shou= ld mostly be handled as a "SYSPDIO" which they called system physical disk IO, which is a talking straight to the disk. That is handled the "mfisyspd" of= the driver. it's kind of strange mode. The real fix is probably to remove the cdb[0] !=3D 0x28 && cdb[0] !=3D 0x2A and always run mfi_tbolt_build_mpt_cmd and not fall through to "DJA NA XXX SYSPDIO". I never found out why we would need to do that check. I put that message there so if it happened we can try to figure out why. Since I've n= ever seen that happen we can probably remove it. --=20 You are receiving this mail because: You are the assignee for the bug.=