Date: Fri, 09 Feb 2007 00:52:14 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Michael Nottebrock <lofi@freebsd.org> Cc: gnome@freebsd.org Subject: Re: HAL on FreeBSD 5.5 redux Message-ID: <1171000334.67014.18.camel@shumai.marcuscom.com> In-Reply-To: <200702090634.56455.lofi@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, 2007-02-09 at 06:34 +0100, Michael Nottebrock wrote: > While regression testing a few new patches for KDE's media kioslave, I found > out that the FreeBSD 5.5 fix for cdroms as committed to ports doesn't > actually work - because of this code: > > /* Better to assert here than panic the machine. */ > /* XXX Should this be a conditional? How likely is this? */ > assert(cdrom->channel >= 0); > assert(cdrom->device >= 0 && cdrom->device < 2); Which assertion is actually failing? What are the values of cdrom->channel and cdrom->device? These assertions are to prevent a bad value from being passed to the kernel thus resulting in a panic. If these assertions are being hit, then the probe should terminate on a SIGABRT. > > I don't know what this is supposed to do (avoid using both atapicam & atapicd > devices?), but it does prevent detection of any cdrom volumes here when > atapicam is disabled. I have two cd/dvd writers (acd0 and acd1) in this > machine. > > I didn't notice this earlier because I skipped hal-0.5.8-20061224, but I did > go back to it now and can confirm that that version doesn't work either > unless those lines are removed. There was a recent change that went into HAL to favor atapicam installations over those without. I wonder if this could be causing problems. Please provide an lshal. Joe > > > Cheers, -- PGP Key : http://www.marcuscom.com/pgp.asc [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQBFzAwOb2iPiv4Uz4cRApkNAKCOsnXQxUcnACKEit9kjYJJGB5QBACcCEwV oKMDAxeaftsuTJ4bV90e5/c= =Z3bu -----END PGP SIGNATURE-----help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1171000334.67014.18.camel>