From nobody Sat Aug 8 00:44:03 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hH2MR75PSz6mZMJ for ; Sat, 08 Aug 2026 00:44:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hH2MR3rL5z3wj9 for ; Sat, 08 Aug 2026 00:44:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786149843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a7MiJFFd9Q5GNswCiZHrNSrhYEB2aI6FAYs+XyvUkHI=; b=TJF9PQAiXVyi8pWOWnnub5kDjN+W5E4uQ0pO9ZXgDrg8p75PkdzMT426PsWpcdwg4oixpO xeLjRCoOjEUZdBfPax/cEp43mfNAjB9WItv7dfiTk6WG0pgRKEMRH/J2x2pnBctvLLSj5U GX23s+bQfp7WXjjSfiLmAJSvo6792OEaGgtWs9xH+5wjPdkqqMwx9BT5bKciOKOXzE8Vt1 E1/UZ2YG6fU+27Qx/0tqyQrX4AYO0Ogsgg9Dm7NhAgVB+eXOjihsDfsIVZNrFCczWNiDOB PRpNrh2q5UwHPSFbrXT+g4zjCK0k7WTF+f9gZDWcfSqp/Cgo3PTcx44HR241eQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786149843; a=rsa-sha256; cv=none; b=oxgxfGkIQDwH2yqkHMLTEC7AnVc+8OxvTiygAQ/z6S4GV79aMsCWgVDndr77HCUucWvofo hfHS4zA6Jf0+dRLqzK3xShd8iKS/+nmkI4AqBFnLDEHlyTSPZQf+b0hGnmJdNL3iuE/nwZ StjjlkOoaZ0ktxai2dLMVt7/8H3oMWQHA1wwbVqLQC8kkUl/9lo7J6tbM67nfgkcIoEU+C i/kdBZoDpI/o88SG/cYI+YkE4Bkzc64dZCPnjmeUjnZE318hFvPQIqMZpSe9NlHzwm2x9R 1Nper4SoAfB/p4vmHLDxX5+x0MuGp/IhO29ucvGRf7xXq0ufIKVxPwSaWwyOvw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786149843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a7MiJFFd9Q5GNswCiZHrNSrhYEB2aI6FAYs+XyvUkHI=; b=fL71HSC67fqHnHWMVSspo6lxInAsAbYqAfg4v9wufhPuC7vwhuHxk7CtcgzlYhuLKmnSP4 v6u43MyijzVS76KV4hh03d6YuSeVFx8dn4EbUFvir06O2yM+MJXw2mrx5QSg+2w3QICo1P lW5dsV8SI10IUX1tBDVJn6PfXXb8Mjf/pr3TyTo9b26AC5MV7eV7QA4hNFzDenG4Pke0FI n8JHiH3bKihKRfKeBgtgVywXcGXbcT3xw9nKe5QPwfp+OdOHjwJ0ps58jAxMQJ5vps6dl3 blZ3MMfZ/Xom0DF17pIElH52rD3gHuxvUjptwvFFjpyocOv06ZfnCPIZv8t9Dg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hH2MR2cSmz188 for ; Sat, 08 Aug 2026 00:44:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3fac4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 08 Aug 2026 00:44:03 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: b84a50bd0e85 - stable/14 - ixv: fix multicast address enumeration List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: b84a50bd0e850575be99c7f798ccc7c89796073c Auto-Submitted: auto-generated Date: Sat, 08 Aug 2026 00:44:03 +0000 Message-Id: <6a767bd3.3fac4.28bbdbb8@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=b84a50bd0e850575be99c7f798ccc7c89796073c commit b84a50bd0e850575be99c7f798ccc7c89796073c Author: Kevin Bowling AuthorDate: 2026-07-28 11:06:23 +0000 Commit: Kevin Bowling CommitDate: 2026-08-08 00:40:56 +0000 ixv: fix multicast address enumeration if_foreach_llmaddr() adds each callback return value to its running count. Returning the incremented count made the address indices grow as 0, 1, 3, 7, and so on, eventually writing beyond the multicast address array. Return one address per callback and stop copying when the array is full, matching the ixv-1.6.12 driver. Fixes: ff06a8dbb677 ("Mechanically convert ixgbe(4) to IfAPI") (cherry picked from commit 6020de5ad154d54c8b9a838f28612c2182330c67) --- sys/dev/ixgbe/if_ixv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixgbe/if_ixv.c b/sys/dev/ixgbe/if_ixv.c index 8a1c1aae041d..24e6fa714a7b 100644 --- a/sys/dev/ixgbe/if_ixv.c +++ b/sys/dev/ixgbe/if_ixv.c @@ -842,11 +842,14 @@ ixv_negotiate_api(struct ixgbe_softc *sc) static u_int ixv_if_multi_set_cb(void *cb_arg, struct sockaddr_dl *addr, u_int cnt) { + if (cnt >= MAX_NUM_MULTICAST_ADDRESSES) + return (0); + bcopy(LLADDR(addr), &((u8 *)cb_arg)[cnt * IXGBE_ETH_LENGTH_OF_ADDRESS], IXGBE_ETH_LENGTH_OF_ADDRESS); - return (++cnt); + return (1); } /************************************************************************ @@ -1982,4 +1985,3 @@ ixv_init_device_features(struct ixgbe_softc *sc) if (sc->feat_cap & IXGBE_FEATURE_NEEDS_CTXD) sc->feat_en |= IXGBE_FEATURE_NEEDS_CTXD; } /* ixv_init_device_features */ -