From owner-freebsd-stable@freebsd.org Sun Jun 17 20:04:30 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD87C1007F37 for ; Sun, 17 Jun 2018 20:04:30 +0000 (UTC) (envelope-from trashcan@ellael.org) Received: from mx2.enfer-du-nord.net (mx2.enfer-du-nord.net [IPv6:2001:41d0:401:2100::5:8a0e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 478347C653; Sun, 17 Jun 2018 20:04:29 +0000 (UTC) (envelope-from trashcan@ellael.org) Received: from [IPv6:2003:e9:7f3e:301:6061:d32e:91bf:aaae] (p200300E97F3E03016061D32E91BFAAAE.dip0.t-ipconnect.de [IPv6:2003:e9:7f3e:301:6061:d32e:91bf:aaae]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx2.enfer-du-nord.net (Postfix) with ESMTPSA id 4184tw6FypzGY; Sun, 17 Jun 2018 22:04:24 +0200 (CEST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.100.0 at mail.enfer-du-nord.net Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: syslogd became silent between 11.2-PRERELEASE r334874 and r335282 From: Michael Grimm In-Reply-To: Date: Sun, 17 Jun 2018 22:04:22 +0200 Cc: "ed@FreeBSD.org" , FreeBSD-STABLE Mailing List Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Ed Schouten X-Mailer: Apple Mail (2.3445.8.2) X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,RDNS_NONE,TW_SV autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail.kaan-bock.lan X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2018 20:04:30 -0000 Hi Ed -- > On 17. Jun 2018, at 19:27, Ed Schouten wrote: >=20 > Hi Michael, >=20 > 2018-06-17 17:52 GMT+02:00 Michael Grimm : >> I do believe that this commit might be the cause: >> = https://svnweb.freebsd.org/base/stable/11/usr.sbin/syslogd/Makefile?revisi= on=3D335059&view=3Dmarkup&sortby=3Dfile >=20 > Thanks for reporting this issue. I just did some debugging on my > system and I think I was able to reproduce this issue. It seems as if > I made a tiny mistake in how I implemented the RFC 5426 UDP message > size limiting. Could you please give the following patch for syslogd a > try? >=20 > Index: usr.sbin/syslogd/syslogd.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- usr.sbin/syslogd/syslogd.c (revision 334706) > +++ usr.sbin/syslogd/syslogd.c (working copy) > @@ -1613,8 +1613,8 @@ > struct iovec *last; > size_t diff; >=20 > - while (size > il->totalsize) { > - diff =3D size - il->totalsize; > + while (il->totalsize > size) { > + diff =3D il->totalsize - size; > last =3D &il->iov[il->iovcnt - 1]; > if (diff >=3D last->iov_len) { > /* Remove the last iovec entirely. */ >=20 > It should be sufficient to apply this to just the 'client' syslogd. > There is no need to patch the central (storage) server. Sorry for my late response, and:=20 Thanks, your patch fixed it! I am not that much experienced, but that's what I did: #) svn update -r 335059 #) applied your patch #) recompiled world and kernel #) reinstalled world and kernel #) reinstalled my jail's basejail (ezjail technology) #) reboot -> return of syslogd clients being able to send syslog messages from = jails to host's syslogd I hope that this is sufficient prove that your patch will work? Thank you very much and with kind regards, Michael