From owner-dev-commits-src-all@freebsd.org Fri Mar 5 18:26:39 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 353DF562A28 for ; Fri, 5 Mar 2021 18:26:39 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DsbmH0RZrz3Gtr for ; Fri, 5 Mar 2021 18:26:38 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qt1-x82b.google.com with SMTP id j3so2432349qtj.12 for ; Fri, 05 Mar 2021 10:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=flrH113JdFRIVsfg5/2Rd14lVqZVSPGj2e/aMxTbf8M=; b=RRl8I5fwcD+OljjF5gyowa33GtB+slkqw0rZiXaKeJTSozOK+awUeFpF6F5FCLQ2IO FpnlFlEF/NsYUENOjBUIW5+0xyU1D9kyDyMZJKwo66HbkFj/2MYLcSEPmwXJQ0lP3fUP vkp5yhmWUHkPotNfPie+0jibbnRhabCFVb+VXul3yMEdWYQT0SPqhen50Xn7Imb6hP06 RnOMcH11alj+5PdvYG7kimWLfIInXwxDNN6A4TRtAjs+mYRDENa1VWKqRMK26D8VNBKl LlageTBFFp/goiTeUFPmaK7CH7sJ+fk72wXA4Uqq45ftymdzblLaPtnHzyhk1XpHEck9 bJEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=flrH113JdFRIVsfg5/2Rd14lVqZVSPGj2e/aMxTbf8M=; b=Z6pe3VbS9V/tI9AZEWXEB2hXfbJDewDBL+qX+r5/12RLGJA16gd4f2GbWuiJK5xrL3 mP9Fts8CfM4+or9DvzYDliRUm7o0uR1NFBzeZCCnESydPwEVwg4Lig1NJjZGIemiLFBB 2aGN2i+TjdYgt9nAzNixcf65XPuTDfqRzZmqvR1M6LSRKzc5UoK8nfVBa+S94+opvwt/ 5WMtgXmYf8LNaIeuKKEChSo7K/cSy9qz8njIzplN0xtdsdSsAmUB5DL0xESQV5n22Tai 0O+DdUMFJrm06NGAhPEqJy82EmimCtWfApDGQg7nwzvevmxdyiuXzrp4oNeGhFSBJUAj ywcw== X-Gm-Message-State: AOAM531HubcUIAY12POMY+O7hOeyc28MEsWpf8Zt5pWsYvdXMfuZutV5 2rsZBjae5i272WnwQidF3inMaA== X-Google-Smtp-Source: ABdhPJzoQpXvd5HsztiVcTl02JrzEJCFPraoNQVu37rktMGMW5Bp+YGa1vyyVA+c/zs749ourHykKw== X-Received: by 2002:ac8:1301:: with SMTP id e1mr1437825qtj.96.1614968798058; Fri, 05 Mar 2021 10:26:38 -0800 (PST) Received: from mutt-hbsd (pool-100-16-222-53.bltmmd.fios.verizon.net. [100.16.222.53]) by smtp.gmail.com with ESMTPSA id o76sm2325077qke.79.2021.03.05.10.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 10:26:37 -0800 (PST) Date: Fri, 5 Mar 2021 13:26:36 -0500 From: Shawn Webb To: Gordon Bergling Cc: Mark Johnston , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 89b650872bba - main - ktls: Hide initialization message behind bootverbose Message-ID: <20210305182636.y6gi3injvqvd2yu4@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202103051815.125IFDNK001016@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hudbptwoe4hv37it" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4DsbmH0RZrz3Gtr X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 18:26:39 -0000 --hudbptwoe4hv37it Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I wonder if it'd be worth it to report such data via sysctl. Thoughts? --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc On Fri, Mar 05, 2021 at 07:23:56PM +0100, Gordon Bergling wrote: > Hi Mark, >=20 > is this change not a little bit to aggressive in terms of dmesg cleanup? >=20 > There are a lot messages about what subsystem is initialized with > how many threads, like for example TCP HTPS and TCP BBR. >=20 > Hiding this information could be suboptimal for some users. >=20 > --Gordon >=20 > On Fri, Mar 05, 2021 at 06:15:13PM +0000, Mark Johnston wrote: > > The branch main has been updated by markj: > >=20 > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D89b650872bba2e4bfbc94a20= 0946b461ef69ae22 > >=20 > > commit 89b650872bba2e4bfbc94a200946b461ef69ae22 > > Author: Mark Johnston > > AuthorDate: 2021-03-05 18:11:02 +0000 > > Commit: Mark Johnston > > CommitDate: 2021-03-05 18:11:02 +0000 > >=20 > > ktls: Hide initialization message behind bootverbose > > =20 > > We don't typically print anything when a subsystem initializes itse= lf, > > and KTLS is currently disabled by default anyway. > > =20 > > Reviewed by: jhb > > MFC after: 1 week > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D29097 > > --- > > sys/kern/uipc_ktls.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > >=20 > > diff --git a/sys/kern/uipc_ktls.c b/sys/kern/uipc_ktls.c > > index 5125061e0879..1fd1eca39b59 100644 > > --- a/sys/kern/uipc_ktls.c > > +++ b/sys/kern/uipc_ktls.c > > @@ -495,7 +495,8 @@ ktls_init(void *dummy __unused) > > } > > } > > =20 > > - printf("KTLS: Initialized %d threads\n", ktls_number_threads); > > + if (bootverbose) > > + printf("KTLS: Initialized %d threads\n", ktls_number_threads); > > } > > SYSINIT(ktls, SI_SUB_SMP + 1, SI_ORDER_ANY, ktls_init, NULL); > > =20 > > _______________________________________________ > > dev-commits-src-main@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main > > To unsubscribe, send any mail to "dev-commits-src-main-unsubscribe@free= bsd.org" >=20 > --=20 > _______________________________________________ > dev-commits-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all > To unsubscribe, send any mail to "dev-commits-src-all-unsubscribe@freebsd= =2Eorg" --hudbptwoe4hv37it Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmBCd9oACgkQ/y5nonf4 4foCQA//TMnPacsJYnVvGpuO9qQXO/WSYvaTkREdKHzrIK4LV6XAG79dCPlob5xU A+h19EgFGMRkSniQgo6uaFg58T3H+1chiI9+flVgAJyLA+iykvEHdNQQjQ3o7455 v4m/g1uAA1B9ELeM3CyC8gUoDroQzYJQPq7ZU0AtnS4iRlUMEOH9Nv9xhqAntTaG 4JmPaw/MTwvSxzJIahQMCFNw+n1xFezH8BytobVmxdoSV2ikOf0/SPj/e64SFpG1 PIS/4MtIkZr3fAPMWKCenK628K/ckP1bM/1CsOu3x9p2UgDq3r7L7ey3TXda47qE 2NW8fxocoiyDdL0erA+V8lbSIaHiEy4jlSApg3kIUiGkvpyQWeBt7plI2BOMjdHH tZIfvsYsxFV15a0O/19jiuUJao63hNThPRrV47ujikuxw8FsE4UIMqdeqqZTEOmL 1K7dH+mBYe6jWHpBtiZBfAb4T0upFUd+Oqn4MOtzrzi71yx88oY23N0zGPyc/rIa KBC8PHwg4usqo4Duhyi/hAYBrGXbMmRPZaB1eFUIMUvazpe7MWPg356DqrZipAv0 1AJhWEvU75JF5+tQH378KWrcIHbkoTrUY7Vo8/qXpJaLI4XnqSGFWU+GbgKOzizk BpO/WWiwMV//W00zu3zxGcit8dQENr9XT0f0LIFTtpVrt+eWj/g= =hI/6 -----END PGP SIGNATURE----- --hudbptwoe4hv37it--